From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932381AbdCIOw1 (ORCPT ); Thu, 9 Mar 2017 09:52:27 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52834 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbdCIOwX (ORCPT ); Thu, 9 Mar 2017 09:52:23 -0500 X-AuditID: b6c32a2c-f79b56d0000012f0-d2-58c16c238998 From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Thu, 09 Mar 2017 15:52:11 +0100 Message-id: <2925309.c9ir13Bff9@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <3285453.g1rFzTv5DW@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsWy7bCmuq5yzsEIg443NhZ/Jx1jt5j05D2z xc/2LUwWmx5fY7U4tuMRk8XlXXPYLA5N3ctosb93A5PFqeuf2SzOrLrF7sDlcfnaRWaP378m MXq8v9HK7vFg6n8mj52z7rJ7bF5S73HlRBOrx/Eb25k8Pm+SC+CM4rJJSc3JLEst0rdL4Mr4 +20Lc8FLvopnrx6yNDB+5+5i5OSQEDCRWH/kDzuELSZx4d56ti5GLg4hgaWMEpvfzGCGcNqZ JI4+m8YM03Fk4VlWiMRyRon7Pbuhqr4ySiw/MIERpIpNwEpiYvsqMFsEqOPYwS8sIDazwCUm iTmTXLsYOTiEBTwlNvzSAQmzCKhK/Hq2jw3E5hXQlPja/hLMFhXwktiyr50JxOYU0JL4fOs3 E0SNoMSPyfegRspL7Ns/lRXC1pE4e2wdI8g9EgK32CU2vPzJCrJLQkBWYtMBqAdcJA5v7WWC sIUlXh3fAvW+tMTfpbcYIezpjBLbf0tAzNnMKLFq9wSoImuJw8cvQi3jk+j9/YQJYj6vREeb EESJh8T7aTuYIcKOEts2G0GC5zWjRMP6NywTGOVnIXlhFpIXZiF5YQEj8ypGsdSC4tz01GLT AkO94sTc4tK8dL3k/NxNjOC0pKWzg/HeAu9DjAIcjEo8vDPsD0QIsSaWFVfmHmKU4GBWEuFV zDoYIcSbklhZlVqUH19UmpNafIhRmoNFSZw3ymBihJBAemJJanZqakFqEUyWiYNTqoGx1vqo NsvLyMwDocbHUuaWT9nG2Mo0RVfPounY/0dqZRFZf42XiNbai+gIB4W81w6Rm3Vl1lanJK+f W1n/feNuUVC+pzBX6vjZirj5sV76T6sNT0leWFh0Sk9l95OtXxcUlWzMEYy6m701VPCGhtHz FR/kLK0CuUJW7vd1lnoYsH71y7mzZacqsRRnJBpqMRcVJwIAKRiqF0cDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jAV3lnIMRBscfK1j8nXSM3WLSk/fM Fj/btzBZbHp8jdXi2I5HTBaXd81hszg0dS+jxf7eDUwWp65/ZrM4s+oWuwOXx+VrF5k9fv+a xOjx/kYru8eDqf+ZPHbOusvusXlJvceVE02sHsdvbGfy+LxJLoAzys0mIzUxJbVIITUvOT8l My/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Zf79tYS54yVfx 7NVDlgbG79xdjJwcEgImEkcWnmWFsMUkLtxbz9bFyMUhJLCUUWL5pg+MEM5XRom/MxYzglSx CVhJTGxfBWaLAHUfO/iFBaSIWeAKk8Ss5SuZuhg5OIQFPCU2/NIBqWERUJX49WwfG4jNK6Ap 8bX9JZgtKuAlsWVfOxOIzSmgJfH51m8miGXTgTb/7mCHaBCU+DH5HguIzSwgL7Fv/1RWCFtL Yv3O40wTGAVmISmbhaRsFpKyBYzMqxglUguSC4qT0nON8lLL9YoTc4tL89L1kvNzNzGCY/WZ 9A7Gw7vcDzEKcDAq8fAKCB+IEGJNLCuuzD3EKMHBrCTCq5h1MEKINyWxsiq1KD++qDQntfgQ oynQhxOZpUST84FpJK8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6p BsaoW5lmXpFP71cI+rStbhS1fzWjmsuh91reRJWaAuf+nTJ2n7fOXH9oXU3f9qlmBa5fS1Ji dmhbX+v/s1rpWPtPJa4bwdOmLdVbwvfFptowlnmi8+lZDmz6ZZbZzRNWPNf+UOgc8se7aYv5 /ieFC9hfldofzxSozqiUYHkqFSTIlX7kS2/AFiWW4oxEQy3mouJEAGFFAGvrAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309145219epcas5p38b1af654dd0a4b04bd02a488051c065f X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170309145219epcas5p38b1af654dd0a4b04bd02a488051c065f X-RootMTR: 20170309145219epcas5p38b1af654dd0a4b04bd02a488051c065f References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <20170309135714.GJ21222@n2100.armlinux.org.uk> <3285453.g1rFzTv5DW@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, March 09, 2017 03:42:49 PM Bartlomiej Zolnierkiewicz wrote: > > Yes, it's very obscure - but what it comes down to is the silly way the > > "ISA" IO is handled on the platform (which depends whether it's an 8-bit > > or 16-bit ISA-style peripheral.) The old IDE CS driver _could_ be bent > > to work via a patch like this: > > > > ARM: EBSA110: Enable 16-bit IO type for ide-iops > > > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > > index 047a20780fc1..2eb501d6b5fe 100644 > > --- a/arch/arm/Makefile > > +++ b/arch/arm/Makefile > > @@ -217,7 +217,8 @@ ifeq ($(CONFIG_ARCH_EBSA110),y) > > # This is what happens if you forget the IOCS16 line. > > # PCMCIA cards stop working. > > CFLAGS_3c589_cs.o :=-DISA_SIXTEEN_BIT_PERIPHERAL > > -export CFLAGS_3c589_cs.o > > +CFLAGS_ide-io-std.o :=-DISA_SIXTEEN_BIT_PERIPHERAL > > +export CFLAGS_3c589_cs.o CFLAGS_ide-io-std.o > > endif > > As I've already explained in the past, the proper fix for the problem > (for both old IDE and libata) is to define custom transport ops in > ide-cs.c/ata_pcmcia.c and use them on affected platforms. > > > # The byte offset of the kernel image in RAM from the start of RAM. > > > > but the PATA driver is much harder. > > There are a lot examples of using your own transport operations in > existing code (i.e. pata_octeon_cf.c or drivers/ata/sata_rcar.c). Basically it should come down to copypasting all transport ops from libata-sff.c and replacing all ioread8()/iowrite8() with __inb16()__outb16(). Then you need to add detection of EBSA1100 which should also be as simple as using machine_is_ebsa110() in the proper place. If you ever get to running current upstream on your EBSA110 I can provide you with the draft patch doing this. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics