From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
devicetree@vger.kernel.org, srinivas.kandagatla@gmail.com,
linux-kernel@vger.kernel.org, patrice.chotard@st.com,
Peter Griffin <peter.griffin@linaro.org>,
peppe.cavallaro@st.com, kishon@ti.com, lee.jones@linaro.org,
maxime.coquelin@st.com
Subject: Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
Date: Tue, 09 Sep 2014 14:05:51 +0200 [thread overview]
Message-ID: <2931258.khlMVogpQg@wuerfel> (raw)
In-Reply-To: <1706244.K6iQdujHby@amdc1032>
On Tuesday 09 September 2014 13:52:54 Bartlomiej Zolnierkiewicz wrote:
> I believe that this should use
>
> select GENERIC_PHY
>
> instead (just like all other PHY drivers except PHY_MIPHY365X which
> also should be fixed to use select).
Right. It would also be good to change 'depends on ARCH_STI'
into 'depends on ARCH_STI || COMPILE_TEST', but only if it
actually compiles on x86.
Note that currently both providers and users of the PHY API
use 'select GENERIC_PHY', which probably not what we want:
only providers (like this one) should 'select' it, while
drivers using this interface could either 'depends on
GENERIC_PHY' or leave out the Kconfig dependency entirely.
Adding 'depends on' for drivers using the interface might
be cleaner, but can result in dependency loops.
Arnd
next prev parent reply other threads:[~2014-09-09 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
2014-09-09 9:08 ` Arnd Bergmann
2014-09-09 10:26 ` Peter Griffin
2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
2014-09-09 12:05 ` Arnd Bergmann [this message]
2014-09-09 9:00 ` [PATCH v2 2/4] phy: phy-stih407-usb: Add dt documentation for USB picophy " Peter Griffin
2014-09-09 9:00 ` [PATCH v2 3/4] MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture Peter Griffin
2014-09-09 9:00 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2931258.khlMVogpQg@wuerfel \
--to=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).