From: Anthony Krowiak <akrowiak@linux.ibm.com>
To: Lizhe <sensor1010@163.com>,
pasic@linux.ibm.com, jjherne@linux.ibm.com, freude@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
Date: Mon, 20 Mar 2023 10:47:51 -0400 [thread overview]
Message-ID: <29430ef5-101d-c639-0f64-b9b709d34afd@linux.ibm.com> (raw)
In-Reply-To: <20230319041941.259830-1-sensor1010@163.com>
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 3/19/23 12:19 AM, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Drop the matrix bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 997b524bdd2b..9341c000da41 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -59,14 +59,8 @@ static void vfio_ap_matrix_dev_release(struct device *dev)
> kfree(matrix_dev);
> }
>
> -static int matrix_bus_match(struct device *dev, struct device_driver *drv)
> -{
> - return 1;
> -}
> -
> static struct bus_type matrix_bus = {
> .name = "matrix",
> - .match = &matrix_bus_match,
> };
>
> static struct device_driver matrix_driver = {
next prev parent reply other threads:[~2023-03-20 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 4:19 [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function Lizhe
2023-03-20 14:47 ` Anthony Krowiak [this message]
2023-03-21 13:41 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29430ef5-101d-c639-0f64-b9b709d34afd@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=sensor1010@163.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).