From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56512C433DF for ; Mon, 29 Jun 2020 18:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41ED92063A for ; Mon, 29 Jun 2020 18:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728420AbgF2Sna (ORCPT ); Mon, 29 Jun 2020 14:43:30 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:1808 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbgF2Sn3 (ORCPT ); Mon, 29 Jun 2020 14:43:29 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05T62F0i179145; Mon, 29 Jun 2020 02:23:18 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31xkqjaqjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jun 2020 02:23:17 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05T62PWK179837; Mon, 29 Jun 2020 02:23:17 -0400 Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 31xkqjaqht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jun 2020 02:23:17 -0400 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05T6L5Tu011514; Mon, 29 Jun 2020 06:23:15 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma04fra.de.ibm.com with ESMTP id 31wwr80whk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jun 2020 06:23:15 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05T6NCjx2621908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Jun 2020 06:23:12 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 46019A4053; Mon, 29 Jun 2020 06:23:12 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14DC8A405B; Mon, 29 Jun 2020 06:23:09 +0000 (GMT) Received: from [9.102.0.109] (unknown [9.102.0.109]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 29 Jun 2020 06:23:08 +0000 (GMT) Subject: Re: [PATCH 02/11] powerpc/kexec_file: mark PPC64 specific code To: Christophe Leroy , Michael Ellerman , Andrew Morton Cc: Pingfan Liu , Kexec-ml , Petr Tesarik , Mahesh J Salgaonkar , Sourabh Jain , lkml , linuxppc-dev , Mimi Zohar , Thiago Jung Bauermann , Dave Young , Vivek Goyal , Eric Biederman References: <159319825403.16351.7253978047621755765.stgit@hbathini.in.ibm.com> <159319829236.16351.3935863082429593906.stgit@hbathini.in.ibm.com> <68d59c00-da02-b362-7bd9-a9631eca0fdd@csgroup.eu> From: Hari Bathini Message-ID: <29542b4a-eb44-5330-60e8-c0b0d294d72f@linux.ibm.com> Date: Mon, 29 Jun 2020 11:53:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <68d59c00-da02-b362-7bd9-a9631eca0fdd@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-29_04:2020-06-26,2020-06-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 clxscore=1011 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 cotscore=-2147483648 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006290039 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe Thanks for the review... On 27/06/20 12:12 pm, Christophe Leroy wrote: > > > Le 26/06/2020 à 21:04, Hari Bathini a écrit : >> Some of the kexec_file_load code isn't PPC64 specific. Move PPC64 >> specific code from kexec/file_load.c to kexec/file_load_64.c. Also, >> rename purgatory/trampoline.S to purgatory/trampoline_64.S in the >> same spirit. > > At the time being, CONFIG_KEXEC_FILE depends on PPC64. Right. > Are you planning to make it work on PPC32 as well ? No. > Otherwise I don't understand the purpose of this patch. But I want to make sure the changes I am adding in this series do not get in the way of adding PPC32 changes whenever they are submitted as there is common code currently and some more of it in the changes I am adding in this series... > Also, what is being done in this patch seems to go far beyond what you describe above.> It is propably worth splitting in several patches with proper explanation. Hmmm.. I don't see any other reason beyond what I mentioned above. Will try to split the patch but the changelog would still be the same, afaics. > Christophe > >> >> Signed-off-by: Hari Bathini >> --- >>   arch/powerpc/include/asm/kexec.h       |   11 +++ >>   arch/powerpc/kexec/Makefile            |    2 - >>   arch/powerpc/kexec/elf_64.c            |    7 +- >>   arch/powerpc/kexec/file_load.c         |   37 ++-------- >>   arch/powerpc/kexec/file_load_64.c      |  108 ++++++++++++++++++++++++++++++ >>   arch/powerpc/purgatory/Makefile        |    4 + >>   arch/powerpc/purgatory/trampoline.S    |  117 -------------------------------- >>   arch/powerpc/purgatory/trampoline_64.S |  117 ++++++++++++++++++++++++++++++++ >>   8 files changed, 248 insertions(+), 155 deletions(-) >>   create mode 100644 arch/powerpc/kexec/file_load_64.c >>   delete mode 100644 arch/powerpc/purgatory/trampoline.S >>   create mode 100644 arch/powerpc/purgatory/trampoline_64.S Thanks Hari