From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935645AbcKPVbD (ORCPT ); Wed, 16 Nov 2016 16:31:03 -0500 Received: from mail-db5eur01on0041.outbound.protection.outlook.com ([104.47.2.41]:40864 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932224AbcKPVbB (ORCPT ); Wed, 16 Nov 2016 16:31:01 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits To: John Stultz References: <1479315472-5245-1-git-send-email-cmetcalf@mellanox.com> CC: Thomas Gleixner , Salman Qazi , "Paul Turner" , Tony Lindgren , Steven Miao , lkml From: Chris Metcalf Message-ID: <295ab33e-45da-af64-6716-c8f387a0cb20@mellanox.com> Date: Wed, 16 Nov 2016 14:56:07 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BY1PR19CA0013.namprd19.prod.outlook.com (10.162.139.151) To HE1PR0501MB2764.eurprd05.prod.outlook.com (10.172.125.18) X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;2:hGIVQ1RCJC6zD5iDc+jqfGnLnDQOsb4p1QYYS9X03zSG9AOpoORktj7C4ZPGslMdS8tK4b+wqepp7pTwk5meJOG45mKadKbfCpeG7ryz0qG/PekpyoqU6n2UwueneXdD4wAKqh8J81iaFG7HRvo5MTr6Bt1FphjYvfdVw6iVtlo=;3:cZlNzbXOwhfI6U+7EYoh+pyD6fHRdXr/y7ROtQLzXdoiyG2IG+ITv164RHb5Uzg7as99pnhv9vqnIvcNn5eOf1lW5ONWfNzG2e40P8fG7sBPUvYH+3mru4QN463XmQpiL2jCsrYy7Dbh2Jt0epTlRe3hLFhW03C5CvKqAWymj0U= X-MS-Office365-Filtering-Correlation-Id: 1d75b42a-a33d-4b09-ed94-08d40e5aa474 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0501MB2764; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;25:lNLHcQrs1NTSFJnmTTjuZm7IOAGhda4TyY7DGzZfPL4sOG1OZcdK7HKEOv8kmQhT7QvH8/CS7JqFd1QBvrxMcfoflaGIrTrchFCB5hWu+zjprZUuJ3GunHC7ml9fL6iq+1HpkBNX1H2vEf/8F7DoPgSjGWk9sgK/vkVt4/P4E1NeI4EmIf3iTCI0jhm2j0cB3letpHMmTmORsAN0eqZA5WmQ8Lnqt1EQYLDNRXaSiPACv5VioP2ZKc/BcEyNgyH6VC9kSTsh5sc+mP/AwRUifMpzo9D/E6f7UbTLIpid9bQb8BfXlY8yn2MmJZDOMA9Zd4vAOGFDfZypUBZtWZbj9d0RCkLx3KaTVLAQYNBraCTfPFEX2RNj47nYlrLyMSddlNnTScvVNivXpsIliA5DFHJPsScPfXFaP1hvV+Whuo9gzI4aIbppnAEi+uudPppbt5uUbqqzjwnIttDUGQoAtC08ZHtu3C6X0uGklfVGHgObHru9NDp0p70xeP2rsQ5/qrJge+xoeuw5fhI5F/nnkgIUD1a3d33Ad/AJoeVEmxMMiHrhl4CSEL5TqNh/I+/ChU7aeZYfiT1Oj1gHsit6TowwWJ5nS7XvJnYcNh+LCAiqIDpZLF3iCx1cmxXfADvpO3Sak6q0PtH1Dac4tOI6YDLR2+09OMvxGYo9c5ozrQdTb02Ka9vbxGE4zbSPpxaN4tLnca2ECTba3x8HgqpAwAYaWNjUFTABAjuOnAA2BZ0FsMEA9FCnDJoOGoKF0o7gSl2u2+zT9qG9RHfqNKz1X7J0bH9+Sc/YKe4gU22oBf5zCNAFhPDIBwgol6E7bLWyHWhR00mJh7+WOq99ugH0CBiPK3vDkJwjNxizDUXsegJrRqoBliAteOYL1ItY4nhD X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;31:QJVChESv/Rp1q/IQsDE2WjiJQDKpLM8AN6uzpL6+KrBWzSOz6/6yWaZNCUvEs07sgveMgS6fFchctCbPB63MED8AHOtan1U4ljKUfsWKh+zRTc2Nm12B89RW5/r/wHrCFPj2I50NK7G3gtU50Ioetpq2PgTjjzXCEvzgpy3/VlJ25WNKx8p42asLwGHfykCbj4dqWO4p4kQZpVJ6ZOEKNCSzclZfgI0O2oRzfabG062gwaeSa2e4xwKetblMfjfdB3WOxmkm3Bu2EUQGke0GqQ==;20:oOKUK2nWsEUhYgbw0IlmKdEW2/K2jmqfDoHDiBnemwWWyvOKijcoYPhR4NbRJ4GOpdNY/6d3P+by/vA/+0LuSzWVXiTwvzykCqKgEGBLWI2EMHuICoVyXaPUNru9eZ+MID43xjfZyJueFJsOWJidJiRRWHx56hAudQB5ySa5ygEO9qQB008zfmRFe4CbKpClsY1nPhKcFGohse3QlA1XVUAkSPupgso+9MT11a8jTKmNmmhxHWB0v0wZQIQfziMnOCHVYoWsT+7yw0yEsIavBCx9fchk8/hhQEhp1JwebJXWO3QBEER5rtHAOrfUZr817AIyw4MzeL0NpLiKLivfs+LhRISkWjktWzrjxoB2dWupoqnz2taQq6r3z+FLD+bmcWLqMu19xfyJA2iNkMjNXyjXb4DjVwhfUgSosf+hrssp+qBjXG0hskaA3Hl23fCSg00wGUIbF0othyHh4iS0Ix91hipAWWNFs04sBS/gzzhFZWx+cSD60Eyw6MsH4MuQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6061324);SRVR:HE1PR0501MB2764;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0501MB2764; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;4:q/9ErzROzrMHcMkiSK5a2zM3FsSvdJvRqBaSjhqxg22QTgaZoD4GGl5OjH88GQyZH9bHJDjRaN4BEamhayhQznH6UcDR9B8PF5soPcP4moaIAQCqdbNBTBd7AcDWWt3wt1Q1fOIaI428M7cowZnVG/beINKa/B/GTD2JeGT4kMxaMlFT+WhRHkC7CjuEd3TWL9vSX6Bsb5abCA/zrcCr3leKXlMjHFHVXaa9GbKC/z61wBqOr9ESZggEIT9LTidzqQlYb8zPcqbIbtRu06TswGFoaQdc3oSmFlxCt8iQwTA5fETBOQnLy4jYKT2Yvtz6i7RY80r1lPVZveB0s2O+o95VfECW8A3wdL68pBOerV/0ur3VlQiq3cAWf4jdKQ9Qp1QGX0hBsHTlC/qyAecB+Wt9l90ToveWbUWcMTqolMpuXfym76eR+JHAhqBb2kJOAKw6P7xu1EZ0KawZ5WtR9vhQdUZvwJcDeCr1J+PLRaw= X-Forefront-PRVS: 01283822F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(24454002)(189002)(199003)(377454003)(76176999)(2950100002)(81166006)(23676002)(101416001)(36756003)(81156014)(106356001)(7846002)(65826007)(8676002)(42186005)(110136003)(77096005)(64126003)(54356999)(31686004)(92566002)(93886004)(50466002)(68736007)(6916009)(105586002)(5660300001)(3846002)(4001350100001)(230700001)(7736002)(50986999)(66066001)(2906002)(65806001)(33646002)(47776003)(189998001)(229853002)(6116002)(4326007)(305945005)(65956001)(86362001)(6666003)(83506001)(31696002)(97736004)(15760500001)(21314002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0501MB2764;H:[10.15.7.187];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1MDFNQjI3NjQ7MjM6WitIM2ZkenZ6UlBocWhEVFBPdmozdHZT?= =?utf-8?B?eVlFSjdYaFRmcVZsNnJmb3FibnFTZnZnNDBVWmNkS3lSVkJPbDB0dmtiM1JU?= =?utf-8?B?WkowSEU3K0w1K1VFa3lkbFA0bnJhY0VGaWhnUVB2MElMVWUyS0pPalZraGdB?= =?utf-8?B?OHZLOERIcEgyMHh1NjZWWnlZWnhPNnRpb1pMQVdhbTJVZTZyZlVRV3pxUlYy?= =?utf-8?B?cm1RclRKWkFkQzVsUjdQYzlFcTlXdDVCS296eFRPY3hBU3VUckFoNTA4Nkxt?= =?utf-8?B?emY5amRic2lOdXhQb2UwWnF0S3dhR0hWUTVrTDAxUGJvMm82Q2didFU4Yy9H?= =?utf-8?B?dmpvci9ZLy9sakg4RU1ZbjZJWjZxT3RoaWZJRzVtVTl2SG1BVEJ4Y0FBd1FJ?= =?utf-8?B?OTJVSitlYU5sZFV1aC9IemFvenYvSHEzaUNNZThJYldlR1NkYUNYS3VlcGti?= =?utf-8?B?YzdhZXcvb1plZ0U5RHluL3BnN21QQ1YvRXdQMS94S0pUT3hQN0ZNT1hkUWxT?= =?utf-8?B?S2RWRWczQktLbEEwVW5ZcHE1RUxFV1JNZkp6NzNZSk9QQkRnUjFsZGtQVTFJ?= =?utf-8?B?UjgvWHZ2eFdkSHBndDJZeVkzZzdSbnFmbmd4Qy9ZNDRPZ09SSkorSkx5UkZv?= =?utf-8?B?OEcvVkpla3hWOUZoUGpwZ3FHYlFheVlBcnYwMERXS0IzdEVyaVhmOS9LR28w?= =?utf-8?B?OVpUdHpHL3phbXpGSG9vSEZ2NXR1RWlCcUN6V2JPMTJPVHI2V3BnZk1XNmY5?= =?utf-8?B?V2NTR3o3aU82NHZrTTlFYy9vTHBOc1puSHR4eXhFdjhZZlFzeEV5REdqd0VW?= =?utf-8?B?V0ZFNnhiN0NwR0E2aXkyNE9qRHczb3A0OGc4R2FZRnEzenF0b0RrdnlhQVR5?= =?utf-8?B?Ly9zSlhETnZsVkI2R2tOZmhJNUV5WEJpaHY3aGNsRGNmdzczcXM0R1V6b2d4?= =?utf-8?B?Q3F4eVZhTXMweEpnMi9LY0hTamkvS0xGVllhVWMrSFJ3MXAwNEw5Vnd3SnRU?= =?utf-8?B?QkdIOEE0ZzdLNEpma3pHZk9IMEUxU2w5RkhQU1hvRzZZdHVSQ2dkTmovOWky?= =?utf-8?B?aHY3NFZHeU5vWUxDbk90RVBmQVhnLzJINXVCNkw3RGxmQkhET3NlMXQ0bU1j?= =?utf-8?B?bFJWYUpyeFdzK21mL1JyQVRTa0RnTTErdHlxbXk1emlGUkVLdzErTW9zZnNC?= =?utf-8?B?V2FZUms0aEdjZFM0c25xTjFmYUNBcUNlZTdhcXA5RTVBd1VFK2NNeS8rVm53?= =?utf-8?B?NmhOSGRXWmRPYzI4YkdKNmVoQ2xxSFRidHgxY29OcFkrMFFBRFlxUVdUWi9s?= =?utf-8?B?MlVqY2FDeG1DMVg2cnJVeGc4TDVQNjAxcGpxcVZGQVdMUkRWQWIwSEpWZWl4?= =?utf-8?B?aDZMdHFSRFdnQmdYb3NLZGJmcWpid3ljc2ZNWE95OTE4U1ZnNU9pcEIwRUh0?= =?utf-8?B?c2NtN25nK0FSSWNic3U1RUMxcjl0UnhJRCsvMWY0SU9zN3cySVdPNW5KNXhU?= =?utf-8?B?OGh3N20zNzZoZzc1WVMybmZUYnd4YW9OVDhkWTQ2anJTVldVVVEyUnYrNVg2?= =?utf-8?B?ME52UG1zeGNGVDJZd2RyMERXc1pwaFZ6N1IyaE5scEVsUXBsZG5pRjJEL2lv?= =?utf-8?B?MnRXRDMyVW12c1JodlRFNzZpZDJKTXZMZEtlbzhISkZzMWlscDlpbXJpTUxE?= =?utf-8?B?UHVuczF4UjhkbjI5TS8vR0JuRy9uRjVDdjFIdGV4ODNYNzNDM0pSOWk3Qm45?= =?utf-8?B?aTVKL1pjNkRJY1NZbk1zYmxFUnloWkxJelNiUmtOc1UwK1VxbGVtUit2S3M5?= =?utf-8?B?clQ0Wm45RlBEbW85dEU1dmNGQ1RDUDVrcCtPSExaUTNPak11MEszUENtaTVo?= =?utf-8?Q?UPS63SgxuSIoE=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;6:+SAstpaP5JAmUFxhV0cnauBg+27GZPmRMYcD2jC7b2057K6bBqDIpzqt6APu/dCeFnhsHxZB/+QNmiOiTTBtdGfCj/r8MHrg1OmxTIJscNfDovuq2c9m6UngBoqGiK7xiAdYls76kqeWLqrOzL/8YEQLbutmWaGtuw3AnkzQUJhFBPeM2MkePMPTKHP18C8STYs0C3tDGYLnG6iE5uyqhVavdr3jjDCCUBwc6O+fVsCw0sRs6gBmo6khW0L9bipWR2h+k1HhZxTEtJoAP7rVU5ezRJUg8zvuqJUCqPohqQkIWZFMVbWkJQXlTxVLjkxg/rE6DMwhUz2V5RcIkq3+GSBDkLDItEebS7yaD8kQkIiBsDOXE9gMrQLVoB0CVccL;5:Erfg3nT8iN0yMyXiagZwhaFgeqImxrhRoncrsWnfp6/dIbj4b9LJl62vzSj5h6qGldYYaI6XW0HIxP6d6CLPV1YGKnWieka6FkbLOFB3f+7wC0JnhyXRY0us2HZYvppVJNZvu0QlBo+wTkZuaf1MPpQcBhWBhCPpXCwk9gpC5oo=;24:zCsTpp3W8SZ+hCwi2uT8fL30p51F4nzm4fwEPunmd+nPvmTKBUxPy96u343S2EbXTj2J/ekaPDPnJQEKplRIUIrtCesKCYsxccWP60lbLf8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;7:++72+Kb7mYuxt86dl8Q3TjykKWmYSexsJmmigVqzv2t/a8puVi/TCbFrPpYKEMAL0ls8zEhzoPUT1vuBBCG4D0JAwCDozZEyTTzzvHU7NKN2xqjsgaajEeOXdJsQXpKLHn74F2HYn/o0Qm5NchHnARzcpSjAkvT+qzUohGV2PrW9s6Y7+Qcjz9kf2uBXajmBQArbPXBKQ7jijf3KrnOhDjpCc0dm8IBtKklawNufDb0AOgY9lTap4MiNMWdhCqw4DtESLN3mDF/ilPNHxAvGDDrbhbaaIfgiJQWeRMtNE9fDv7msngWTPzw13Qn1eitJsdDN05jwf/3koXeDQTFGxlCT9QxlUVARKdBlp8nnjMw= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 19:56:21.2345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2764 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2016 2:45 PM, John Stultz wrote: > On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf wrote: >> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h >> index 08398182f56e..5444429884b8 100644 >> --- a/include/linux/clocksource.h >> +++ b/include/linux/clocksource.h >> @@ -171,6 +171,10 @@ static inline u32 clocksource_hz2mult(u32 hz, u32 >> shift_constant) >> * >> * Converts cycles to nanoseconds, using the given mult and shift. >> * >> + * The code is optimized for performance and not intended to work >> + * with absolute clocksource cycles, as it will easily overflow, >> + * but just intended for relative (delta) clocksource cycles. >> + * >> * XXX - This could use some mult_lxl_ll() asm optimization > Just as a heads up, it seems your working against an older kernel, as > this didn't apply. Its simple enough to fix up, so I'll do so, but in > the future, please submit patches against something close to Linus > HEAD. Oops, sorry; it wasn't version skew (I'm at v4.9-rc4) but whitespace damage. I assumed if I just pasted the patch into Thunderbird it would work, since it had no tabs. But bizarrely, if I look at the patch in the mailer, it shows a two-space prefix, but when I save the email to a file, it has a three-space prefix. WTF? -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com