From: "Heiko Stübner" <heiko@sntech.de>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
charles.chen@rock-chips.com, kevan.lan@rock-chips.com,
huangtao@rock-chips.com, finley.xiao@rock-chips.com,
david.wu@rock-chips.com, shawn.lin@rock-chips.com,
wmc@rock-chips.com
Subject: Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228
Date: Thu, 15 Jun 2017 09:51:59 +0200 [thread overview]
Message-ID: <2961285.cLXt8uGUMN@diego> (raw)
In-Reply-To: <1497510980-23207-3-git-send-email-frank.wang@rock-chips.com>
Hi Frank,
Am Donnerstag, 15. Juni 2017, 15:16:16 CEST schrieb Frank Wang:
> From: Shawn Lin <shawn.lin@rock-chips.com>
>
> Add "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc" for
> dwmmc on rk322x platform.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt index
> 520d61d..ce30dff 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> @@ -15,6 +15,7 @@ Required Properties:
> - "rockchip,rk3288-dw-mshc": for Rockchip RK3288
> - "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RV1108 - "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RK3036 + - "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK322X - "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3368 - "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3399
you might want to rebase this patch on top of Ulfs next branch [0],
as there is also the support for the rk3328 in there now.
Otherwise looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
[0] https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/log/?h=next
next prev parent reply other threads:[~2017-06-15 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 7:16 [PATCH 0/6] add some device nodes support for rk322x SoC Frank Wang
2017-06-15 7:16 ` [PATCH 1/6] ARM: dts: rockchip: add basic dtsi file for RK3229 SoC Frank Wang
2017-06-17 18:12 ` Heiko Stuebner
2017-06-19 10:34 ` Frank Wang
2017-06-19 12:30 ` Heiko Stübner
2017-06-20 7:13 ` Frank Wang
2017-06-20 10:48 ` Heiko Stübner
[not found] ` <CAFLEztTZPeqbE++uRS-jXYUb7KzSik7=5v8+p07L788HWvwQqg@mail.gmail.com>
2017-06-21 7:29 ` Huang, Tao
2017-06-21 8:55 ` Heiko Stübner
2017-06-15 7:16 ` [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228 Frank Wang
2017-06-15 7:51 ` Heiko Stübner [this message]
2017-06-15 7:16 ` [PATCH 3/6] ARM: dts: rockchip: fix compatible string for eMMC node of rk3228 SoC Frank Wang
2017-06-15 7:16 ` [PATCH 4/6] ARM: dts: rockchip: add sdmmc and sdio nodes for " Frank Wang
2017-06-15 7:21 ` [PATCH 5/6] ARM: dts: rockchip: Add io-domain node for rk3228 Frank Wang
2017-06-15 7:23 ` [PATCH 6/6] ARM: dts: rockchip: add efuse device " Frank Wang
2017-06-15 15:10 ` Heiko Stuebner
2017-06-16 9:24 ` Frank Wang
2017-06-16 9:35 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2961285.cLXt8uGUMN@diego \
--to=heiko@sntech.de \
--cc=charles.chen@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kevan.lan@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wmc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).