From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Sergio Miguéns Iglesias" <lonyelon@gmail.com>, airlied@linux.ie
Cc: daniel@ffwll.ch, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Sergio Miguéns Iglesias" <sergio@lony.xyz>
Subject: Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues
Date: Thu, 5 Aug 2021 14:33:17 +0200 [thread overview]
Message-ID: <296a3a38-2e9c-f3f2-66a8-70f52eaff2eb@gmail.com> (raw)
In-Reply-To: <20210804112053.263887-1-sergio@lony.xyz>
Am 04.08.21 um 13:20 schrieb Sergio Miguéns Iglesias:
> Fixed braces, an unnecessary if statement and added a missing space.
>
> Signed-off-by: Sergio Miguéns Iglesias <sergio@lony.xyz>
Normally we see patches which just fixes coding style as unnecessary
churn, but the "if (rbo) {}" is really ugly here.
So Reviewed-by: Christian König <christian.koenig@amd.com>.
Thanks,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_fb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 0b206b052972..6640b7c947fe 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -54,6 +54,7 @@ radeonfb_open(struct fb_info *info, int user)
> struct radeon_fbdev *rfbdev = info->par;
> struct radeon_device *rdev = rfbdev->rdev;
> int ret = pm_runtime_get_sync(rdev->ddev->dev);
> +
> if (ret < 0 && ret != -EACCES) {
> pm_runtime_mark_last_busy(rdev->ddev->dev);
> pm_runtime_put_autosuspend(rdev->ddev->dev);
> @@ -196,9 +197,8 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> radeon_bo_check_tiling(rbo, 0, 0);
> ret = radeon_bo_kmap(rbo, NULL);
> radeon_bo_unreserve(rbo);
> - if (ret) {
> + if (ret)
> goto out_unref;
> - }
>
> *gobj_p = gobj;
> return 0;
> @@ -294,9 +294,6 @@ static int radeonfb_create(struct drm_fb_helper *helper,
> return 0;
>
> out:
> - if (rbo) {
> -
> - }
> if (fb && ret) {
> drm_gem_object_put(gobj);
> drm_framebuffer_unregister_private(fb);
next prev parent reply other threads:[~2021-08-05 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 11:20 [PATCH] DRM: gpu: radeon: Fixed coding style issues Sergio Miguéns Iglesias
2021-08-05 12:33 ` Christian König [this message]
2021-08-05 19:40 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=296a3a38-2e9c-f3f2-66a8-70f52eaff2eb@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=lonyelon@gmail.com \
--cc=sergio@lony.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).