From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Marian Marinov <mm-l@yuhu.biz>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Aaron Lu <aaron.lu@intel.com>
Subject: Re: Patch breaks suspend
Date: Tue, 05 May 2015 01:37:33 +0200 [thread overview]
Message-ID: <2970725.6ieOiJg9HH@vostro.rjw.lan> (raw)
In-Reply-To: <55453334.9030002@yuhu.biz>
On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> Hi guys,
> I have Lenovo T520 with one SSD and one SATA drive.
>
> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
> Both drives have bios encryption enabled.
>
> I did a bisect and found that the following patch causes the issue:
> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Sat Feb 22 00:48:31 2014 +0100
>
> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
>
> Modify the SATA subsystem to add hotplug contexts to ACPI companions
> of SATA devices and ports instead of registering special ACPI dock
> operations using register_hotplug_dock_device().
>
> That change will allow the entire code handling those special ACPI
> dock operations to be dropped in the next commit.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Unfortunately I do not understand this part of the code and have no idea what I can do.
> Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
category), assign it to me and CC Aaron?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-05-04 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 20:27 Patch breaks suspend Marian Marinov
2015-05-04 23:37 ` Rafael J. Wysocki [this message]
2015-05-05 5:47 ` Aaron Lu
2015-05-05 8:38 ` Marian Marinov
2015-05-05 12:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2970725.6ieOiJg9HH@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-l@yuhu.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).