From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbbLIIqQ (ORCPT ); Wed, 9 Dec 2015 03:46:16 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:61104 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbLIIqP (ORCPT ); Wed, 9 Dec 2015 03:46:15 -0500 From: Arnd Bergmann To: Xiubo Li Cc: broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] regmap: add 64-bit mode support Date: Wed, 09 Dec 2015 09:45:59 +0100 Message-ID: <2974042.RS5oNhyniO@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1449135113-31892-3-git-send-email-lixiubo@cmss.chinamobile.com> References: <1449135113-31892-1-git-send-email-lixiubo@cmss.chinamobile.com> <1449135113-31892-3-git-send-email-lixiubo@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:KqOgaOD9ifW8J8yw761W8t41qxdwPW6gfWJeqFX0bD95qAlk903 HyRTKrS2iZzPvJCsJMS7YWe2BgfKJ/J4daglFK88y00tu/aWiAB7OGYhEXuSCNx1t4O2j30 HIXJOBZLTXSWw8pS59VrAmi3jp8sy/wNtzTqzKB1SH+lVr9jqJJdSrxoUrsV6sknUjEtP/K qf0w0Yex34ti8+oA6Ekgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:sR+hqMaar/A=:UDE3ZfqpJNfOwUudoOsMs1 CPkbWF4uvFdzRTEcyiXyEWIy9yXm2b4/7DsJdyuEvNF8GhU6DCgsUM9uFjZQr/VaC6ZUQD2B+ R6qzQ5KgOyvUlfGg5iXACBBglTb7rW0O5i27Jwxt6JzO+6cbPUFf2+XV4NXwR1qjbRSe/JjiS +gqJuXQcagNaiZr0e8AcEV5ralTVq/oUYQE7qP2HoXx07LVhkSCIXdjVIcqrZiZKu4Y6tLhi7 HNTqrVxJfSIAnwBkQX0aEJE0v2dE/fme99wBll7Gf4880RtJrg8ByBmUI1GDlzFmSQTnmPqZx 4hTGH2LDWS1k8xZg1Ya6iUvQQmusa7lITwpeaZj//+eJZUqSwVG4v6fnNsZQn7tffr8H16Quj oQlpcws3ggIZJY5FWGRKrdeEVWT8BVjPziAqbTS3pU7eSTuk7avOypxIqB4EXKKVP4jTEKnOn p/wtxlxR89PzQ8nU1VETTb2JnI1d5z37LbqY8ruHFKo0pKeqjuz64VtlitIC5XYHy+uiGny30 /tmwyq3hhO7WB86KgVaC8mlayanGSKbf57zMS+gWQEAjgLcgAsSu7Hgal0iaNmrQStNYZM87Y 0gOL1pFMzVzxNZuCZWiT5IFuYHhTaD+4BkgX7GtfgwqvG/VV5dyD1akCXU9bcfwBNrVg4D4VI FwHmlcQVCAK4ngBBkPhamIXURH++v0eS1XlFVy9iMnX0axk8Lj+lnO4KwWXDdSeu9vLo51TLD kjB3Aj7+JvMEXZGg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 03 December 2015 17:31:52 Xiubo Li wrote: > @@ -2488,11 +2581,17 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val, > * we assume that the values are native > * endian. > */ > + u64 *u64 = val; > u32 *u32 = val; > u16 *u16 = val; > u8 *u8 = val; > > switch (map->format.val_bytes) { > +#ifdef CONFIG_64BIT > + case 8: > + u64[i] = ival; > + break; > +#endif > case 4: > u32[i] = ival; > break; > This now gives me: drivers/base/regmap/regmap.c: In function 'regmap_bulk_read': drivers/base/regmap/regmap.c:2584:10: warning: unused variable 'u64' [-Wunused-variable] u64 *u64 = val; ^ Arnd