From: Wen Gong <wgong@codeaurora.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue
Date: Fri, 03 Jan 2020 09:37:26 +0800 [thread overview]
Message-ID: <297b94fe2eb5a20c75c2095e9640a495@codeaurora.org> (raw)
In-Reply-To: <20200102.162249.948673283541180133.davem@davemloft.net>
On 2020-01-03 08:22, David Miller wrote:
> I don't think this is correct.
>
> The 'hdr' was already "pushed" earlier in this file.
>
> Here we are padding the area after the header, which is being "put".
>
> I'm not applying this. If you still think it is correct, you must
> explain
> in detail why it is and add that description to the commit log message.
>
> Thank you.
Thanks David.
I will add more description and send patch v2.
next prev parent reply other threads:[~2020-01-03 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 9:32 [PATCH] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue Wen Gong
2020-01-03 0:22 ` David Miller
2020-01-03 1:37 ` Wen Gong [this message]
2020-01-03 4:52 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297b94fe2eb5a20c75c2095e9640a495@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).