From: Sibi Sankar <sibis@codeaurora.org>
To: Pradeep P V K <ppvk@codeaurora.org>
Cc: bjorn.andersson@linaro.org, adrian.hunter@intel.com,
robh+dt@kernel.org, ulf.hansson@linaro.org,
vbadigan@codeaurora.org, sboyd@kernel.org,
georgi.djakov@linaro.org, mka@chromium.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-mmc-owner@vger.kernel.org, rnayak@codeaurora.org,
matthias@chromium.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support
Date: Wed, 03 Jun 2020 17:22:54 +0530 [thread overview]
Message-ID: <29826613b412e4f4db4289e292a1fe57@codeaurora.org> (raw)
In-Reply-To: <1591175376-2374-2-git-send-email-ppvk@codeaurora.org>
Hey Pradeep,
Thanks for the patch.
On 2020-06-03 14:39, Pradeep P V K wrote:
> Interconnect bandwidth scaling support is now added as a
> part of OPP [1]. So, make sure interconnect driver is ready
> before handling interconnect scaling.
>
> This change is based on
> [1] [Patch v8] Introduce OPP bandwidth bindings
> (https://lkml.org/lkml/2020/5/12/493)
>
> [2] [Patch v3] mmc: sdhci-msm: Fix error handling
> for dev_pm_opp_of_add_table()
> (https://lkml.org/lkml/2020/5/5/491)
>
> Signed-off-by: Pradeep P V K <ppvk@codeaurora.org>
> ---
> drivers/mmc/host/sdhci-msm.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c
> b/drivers/mmc/host/sdhci-msm.c
> index b277dd7..bf95484 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -14,6 +14,7 @@
> #include <linux/slab.h>
> #include <linux/iopoll.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/interconnect.h>
>
> #include "sdhci-pltfm.h"
> #include "cqhci.h"
> @@ -1999,6 +2000,7 @@ static int sdhci_msm_probe(struct platform_device
> *pdev)
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_msm_host *msm_host;
> struct clk *clk;
> + struct icc_path *sdhc_path;
> int ret;
> u16 host_version, core_minor;
> u32 core_version, config;
> @@ -2070,6 +2072,20 @@ static int sdhci_msm_probe(struct
> platform_device *pdev)
> }
> msm_host->bulk_clks[0].clk = clk;
>
> + /* Make sure that ICC driver is ready for interconnect bandwdith
> + * scaling before registering the device for OPP.
> + */
> + sdhc_path = of_icc_get(&pdev->dev, NULL);
> + ret = PTR_ERR_OR_ZERO(sdhc_path);
> + if (ret) {
> + if (ret == -EPROBE_DEFER)
> + dev_info(&pdev->dev, "defer icc path: %d\n", ret);
> + else
> + dev_err(&pdev->dev, "failed to get icc path:%d\n", ret);
> + goto bus_clk_disable;
> + }
> + icc_put(sdhc_path);
ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL);
since there are multiple paths
described in the bindings you
should use ^^ instead and you
can drop temporary path as well.
> +
> msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core");
> if (IS_ERR(msm_host->opp_table)) {
> ret = PTR_ERR(msm_host->opp_table);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-06-03 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:09 [PATCH V1 0/2] Add SDHC interconnect bandwidth scaling Pradeep P V K
2020-06-03 9:09 ` [PATCH V1 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support Pradeep P V K
2020-06-03 11:52 ` Sibi Sankar [this message]
2020-06-04 11:13 ` ppvk
2020-06-04 17:55 ` Sibi Sankar
2020-06-03 15:30 ` Matthias Kaehlcke
2020-06-03 9:09 ` [PATCH V1 2/2] dt-bindings: mmc: sdhci-msm: Add interconnect BW scaling strings Pradeep P V K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29826613b412e4f4db4289e292a1fe57@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc-owner@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias@chromium.org \
--cc=mka@chromium.org \
--cc=ppvk@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).