From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757886AbcIHIQb (ORCPT ); Thu, 8 Sep 2016 04:16:31 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:53010 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcIHIQ2 (ORCPT ); Thu, 8 Sep 2016 04:16:28 -0400 From: Arnd Bergmann To: Guenter Roeck Cc: Hoan Tran , Jean Delvare , Jonathan Corbet , Rob Herring , Jassi Brar , Ashwin Chaugule , Duc Dang , lho@apm.com, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Catalin Marinas , James Morse , AKASHI Takahiro , Will Deacon Subject: Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver Date: Thu, 08 Sep 2016 10:14:42 +0200 Message-ID: <2992356.ULGoZEEDZp@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160907223705.GA31582@roeck-us.net> References: <1469134557-26869-1-git-send-email-hotran@apm.com> <13081573.BbD3TmEU5Y@wuerfel> <20160907223705.GA31582@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:1hcWaCocEoRZsNZU53HhmlmUKe+/ocATk8iHNPghW+mfGddov+N g5rNnxoruhWaUbwiyJGUFX560xYsuXhjdCB+2Ma57JwpjYrjF155mZodgFd2tzM50Tv25zN /Nv2+Fk4ZRU2Cysvd37ZH9JrYOeq2UEtVQwjyune+kMjJ3Tn3xV0DaZRG1p8ZruUX/xbykO ZxJD4n5EolfEcL6MDUCjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:f14hu40grKQ=:SX+QIcciUiWI2lWCm21vRS V0oSbA/XyYfMyMH1LotAqR+AdzHzPfo+vPxo/Q4j2o2FOAt34i0YZ936vH3k5gsWbTJ+PrU4n bci/JL5CwPCshAao4zrufjsgRslsjFqRF8/KUpV8K4fung3JuIbJVzcvyVE+nvvxRrB4ojBp8 rJ95GvungDP2MGdxn1gLAxvGfup7Sx7/YeqFOO5d+kTDgWUCExklzQHhOAEfJE5DcKNMZ4d9w grek1E66PmKZbvz9I5dnLI5WlMJWAMlzTIcybd2g5E38GujjvsHvSwszzZF+lfoZWvEfB+F0R 5mr60jiA7MMeEndDRTYQNizsn6wbuaWPSdnxzdrTwYiQ3PenZUR+2WBFLgvYpQ/c+tTiUztZa yI5xcdC/MJdwHK0FfNpKkZ5T2zyTMTauJ7iUCpHWuWq5poFvs0bQMHryOM1BXf+kk2dneB1WE tVAXO1inXTpD+phXz3Wqh5dOQKRtqqO3JfFsnotYQBMCzm4IgMOyA1Dqz0myLP/fKv2dYOnv9 uko5MH/HaFsGvKUfE7eRR1L1j/94OdMYVLjmKRWodDhIiPV+UqvHuWouoaVQkC6totBE9IAwW is2QqnoiAioIoH0PgG8IUVnwu3vqbSAHcNmLT08pU34d40APtvgNkdmkvgBiTybdPhfxpAo/6 /o8RvyeJvUT2zwUNfr/UiGFcAO/i1wDzrmgZJbcXF5Zkw/NWiITzlvmU2ZiDRx/9NOGB/DJx0 5ijqKAtGkWjY1FXP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote: > On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: > > On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: > > > + ctx->comm_base_addr = cppc_ss->base_address; > > > + if (ctx->comm_base_addr) { > > > + ctx->pcc_comm_addr = > > > + acpi_os_ioremap(ctx->comm_base_addr, > > > + cppc_ss->length); > > > > > > > This causes the arm64 allmodconfig build to fail now, according to > > kernelci: > > > > 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! > > > > Should this perhaps call ioremap() or memremap() instead? > > > Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64: > mark reserved memblock regions explicitly in iomem") starts using a function > in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory() > is declared as __init_memblock, which makes me really uncomfortable. > If acpi_os_ioremap() must not be used by modules, and possibly only during > early (?) initialization, maybe its declaration should state those limitations ? Ah, I didn't notice that. I guess both patches were correct individually and got added to linux-next around the same time but caused allmodconfig to blow up when used together. Adding everyone who was involved in the memblock patch to Cc here, maybe one of them has an idea what the correct fix is. There are only two other drivers using acpi_os_ioremap() and one of them is x86-specific, so it's still likely that drivers are not actually supposed to use this symbol. Making acpi_os_ioremap() an exported function in arm64 would also work. Arnd