From: Shuah Khan <skhan@linuxfoundation.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Cristian Marussi <cristian.marussi@arm.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4] kselftest: Fix vdso_test_abi return status
Date: Mon, 31 Jan 2022 10:37:54 -0700 [thread overview]
Message-ID: <299a9d32-ec50-029b-b8c7-b89aff6331a4@linuxfoundation.org> (raw)
In-Reply-To: <20220131113405.25977-1-vincenzo.frascino@arm.com>
On 1/31/22 4:34 AM, Vincenzo Frascino wrote:
> vdso_test_abi contains a batch of tests that verify the validity of the
> vDSO ABI.
>
> When a vDSO symbol is not found the relevant test is skipped reporting
> KSFT_SKIP. All the tests return values are then added in a single
> variable which is checked to verify failures. This approach can have
> side effects which result in reporting the wrong kselftest exit status.
>
> Fix vdso_test_abi verifying the return code of each test separately.
>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Reported-by: Cristian Marussi <cristian.marussi@arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> tools/testing/selftests/vDSO/vdso_test_abi.c | 135 +++++++++----------
> 1 file changed, 62 insertions(+), 73 deletions(-)
>
Thank you. Applied to linux-kselftest fixes for rc3
thanks,
-- Shuah
prev parent reply other threads:[~2022-01-31 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 11:34 [PATCH v4] kselftest: Fix vdso_test_abi return status Vincenzo Frascino
2022-01-31 17:37 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=299a9d32-ec50-029b-b8c7-b89aff6331a4@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=cristian.marussi@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).