From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA4BC19F28 for ; Wed, 27 Jul 2022 18:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239745AbiG0Snn (ORCPT ); Wed, 27 Jul 2022 14:43:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242983AbiG0SnU (ORCPT ); Wed, 27 Jul 2022 14:43:20 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB8F11CCC8 for ; Wed, 27 Jul 2022 10:40:28 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 15-20020a17090a098f00b001f305b453feso2963993pjo.1 for ; Wed, 27 Jul 2022 10:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:content-language:to:cc :references:from:subject:in-reply-to:content-transfer-encoding; bh=9ODf3/7a0YWthMFUbQSzorMWt+mXId+4ZYKev6XizEA=; b=oeYciCEYMx/K9VImyELz6jlH+XHh46HGEMQxt3c84YhX/td2/rS+FvJsqTK6woA1AO IZAiiwjFZL/2hSb38TJjx4ST45zgM9t/j6p5luheuQqBlX4ejrvWRqR0xYdJq9wVU7Ug Ij49DaJgPk5LVwdTM2GMB5okdgTpp3+UXCzLMbaTSfoVPQEKiGcL36bJYVrSfc+jW+Bh AkYrL3LVjx+M+F085Dm/UzF0SlxCJGk2G34MRNTUZ8au7T2Oo2P/A6uTYKt5JZ3N3rav 3LcGrCaO33Ue/kBIsq0b2y7+DwBHlZMWCBTWi8iWcLH0W7CIQ0SG0Q9gjO/oT8V64WKW u5oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=9ODf3/7a0YWthMFUbQSzorMWt+mXId+4ZYKev6XizEA=; b=rstxk0U0bUAfttKwHTdSjQ7Dnu0XslN3MVT14IXCt7PZymFpLTYHwQ5OOfsw7IT6yw eu8EP0TuhhPpoDgIfBItLQocEGtFgx6PIZ7l9r7bUhZXQqpnuq5CV3gV42wfoqMtdAR9 4gt6GdJnAgZ0JgBlZ+buj8wqonN2EvNRfwPTUcsHZii5EdG9aKMgh8+7s2Qh8Ba1bGnw qBp+kdrS1TtLSUfsaLeTZboe7Z7nGZ+DOmFF6y7n16jNJHAJKwshuFnb919YWJEdnUMq pkFs58HIceKUgbzJr7thlAsn35AwHpl4qoFWDCNGL0ndmhdqOloAMp88pMpk6u4NkWfg DROA== X-Gm-Message-State: AJIora89uk7k6Jhyv97l4G+OxUKLlLMp8xBWxVpA79XzTie6J/7Sxb7B vcY1a9OYfQhb7R+318WW7LnI0g== X-Google-Smtp-Source: AGRyM1s13Fa1EJMrBTGTG+hbpfKcUTOSzkwGqNkTWYvWM2uPpC7aXcj3AZSburuigniRBSjn0/LFTw== X-Received: by 2002:a17:902:7290:b0:16c:cbcb:3971 with SMTP id d16-20020a170902729000b0016ccbcb3971mr22265567pll.165.1658943627157; Wed, 27 Jul 2022 10:40:27 -0700 (PDT) Received: from ?IPV6:2601:1c0:4c00:ad20:feaa:14ff:fe3a:b225? ([2601:1c0:4c00:ad20:feaa:14ff:fe3a:b225]) by smtp.gmail.com with ESMTPSA id l14-20020a170903244e00b0016d9e53c138sm4480741pls.17.2022.07.27.10.40.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 10:40:26 -0700 (PDT) Message-ID: <29a17172-c8c6-0e69-6e38-e482500d2ae3@linaro.org> Date: Wed, 27 Jul 2022 10:40:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Lukas Czerner Cc: Theodore Ts'o , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+bd13648a53ed6933ca49@syzkaller.appspotmail.com References: <983bb802-d883-18d4-7945-dbfa209c1cc8@linaro.org> <20220726224428.407887-1-tadeusz.struk@linaro.org> <20220727172517.bv2bflydy2urqttv@fedora> From: Tadeusz Struk Subject: Re: [PATCH] ext4: try to flush inline data before calling BUG in writepages In-Reply-To: <20220727172517.bv2bflydy2urqttv@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukas, On 7/27/22 10:25, Lukas Czerner wrote: > I don't think this is the right fix. We're in ext4_writepages, so at > this point I don't think an inode should have any actual inline data in > it. If it does it's a bug and the question is how did this get here? > > The inode is likely corrupted and it should have been noticed earliler > and it should never get here. Yes, that was just an attempt fix something that I'm not quite familiar with. Jan sent already a patch for that fixes it: https://lore.kernel.org/all/20220727155753.13969-1-jack@suse.cz/ -- Thanks, Tadeusz