From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFA3C433E2 for ; Tue, 8 Sep 2020 16:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F22F820759 for ; Tue, 8 Sep 2020 16:43:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GiZ9PzKV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732021AbgIHQm4 (ORCPT ); Tue, 8 Sep 2020 12:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731977AbgIHQmO (ORCPT ); Tue, 8 Sep 2020 12:42:14 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D92DC06121A; Tue, 8 Sep 2020 06:26:12 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id w3so20009263ljo.5; Tue, 08 Sep 2020 06:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wicnMiUF8IEAES1mOlASJ6pW21feYULj1hQyoGrNJ8o=; b=GiZ9PzKVv0xGowTjcuBelk0nGAZ8CNmZN/XNDian8GYz4cI/nhyIrzfg5djb3hrXdz 7PHWVVB+jqmk8PCgYa6B6KraG2PWOYMx/cMRuj/EUQ+4uFfEwUZ9PK1wGRFN7+Ef6xr+ 4p3doArdXHjHfRfs9E4UM1Xjxi4qDH31CQL4BOrB+YFyQ4ueEmgWLOsEHscdiwkhOs/h 8aGKHHtueftJ3VdvIFmKxKUGbF3bn2fb7yh3aPQPYePP/7G2cpB+ESP0vziXunwo9rZH mwhp+aCvv10iIFtnuXcBozQr6E/wiRKekyR20WtaKBx9PeJ/be57LpV0L9kDeYT3l0XV 7hlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wicnMiUF8IEAES1mOlASJ6pW21feYULj1hQyoGrNJ8o=; b=ALlzctXCaLClZETmR0rHrbqeAw1lMwg6hmsuSQyXBCTLbT8k9wB2jO5QXjZSra9IkU WqRJ37SK/iMgDhuyF2CRkOuFU1PYeklbQSMW9L6d+PWnozAq+tzAqgNb7bKxjJF9mZ9r 1o1T6fXQRt5dCgKGcCFkrF6o57xXsTDliCcka3a5hGBf4hLUUz6uoQyiVrLNqI4H7xnh pTdK5qG5Cx+77P9Vy4YqdGJvGlYbUPdd6iRjh17YPTFTy0pmrC2kh/MMpAuOuMdn+OfX W0F+Zcgto1Qp+/6AxXOsYA5GoV3q1rE0X18pGGghcZzx99167NqOBnUs4YD9LETy3HKn NdSA== X-Gm-Message-State: AOAM530pkyRkhOLTqfP3v2jmD3EJCD5v1cuooO3g4brOUE4Lzln2nHww alZjhOCDVkGMbYAR1QNYgq+RTVHNdeo= X-Google-Smtp-Source: ABdhPJwjRn28tbrlSjSLqpSujxV7U3nOFGzuTsHVr0VCdjEwgObVmN3TH0rgRnEnaZVM9uFZ/tb30A== X-Received: by 2002:a05:651c:1253:: with SMTP id h19mr9789853ljh.55.1599571570543; Tue, 08 Sep 2020 06:26:10 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id l15sm10196755lje.16.2020.09.08.06.26.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 06:26:09 -0700 (PDT) Subject: Re: [PATCH v6 24/35] i2c: tegra: Rename wait/poll functions To: Andy Shevchenko Cc: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-i2c , linux-tegra@vger.kernel.org, Linux Kernel Mailing List References: <20200908021021.9123-1-digetx@gmail.com> <20200908021021.9123-25-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <29a288f6-3a78-8006-b457-a6ce766d1358@gmail.com> Date: Tue, 8 Sep 2020 16:26:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 08.09.2020 11:45, Andy Shevchenko пишет: > On Tue, Sep 8, 2020 at 5:11 AM Dmitry Osipenko wrote: >> >> Drop '_timeout' postfix from the wait/poll completion function names in >> order to make the names shorter, making code cleaner a tad. > > ... > >> + time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete, >> + 50); > > Why not one line? > It goes over 80 chars, which is still a preferred max-length, although it's not a mandatory limit anymore. For example I have a code editor setup that is tuned for 80 chars, allowing to have multiple files viewed and edited simultaneously. But I think in the case of this particular hunk of the code, the indentation improvement would indeed overweight the code-length. I'll change it in v6, thanks!