From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E773FC6778D for ; Sun, 1 Jul 2018 00:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A01A925462 for ; Sun, 1 Jul 2018 00:20:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E84xo5eQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A01A925462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbeGAAUG (ORCPT ); Sat, 30 Jun 2018 20:20:06 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:41827 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbeGAAUB (ORCPT ); Sat, 30 Jun 2018 20:20:01 -0400 Received: by mail-pg0-f66.google.com with SMTP id l65-v6so5537930pgl.8; Sat, 30 Jun 2018 17:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lP4IG4mDY9DgV+tOoDW146wl3lit/aOFC7RSHZ9QL6c=; b=E84xo5eQKz4KNGxu7uDS0UKfA3B1D62Zw1K/4tHTOorVNsDWjRY04O1nJH3uDAafsK 7P6C/8dARm1FEPPiOLTvUU9gz7OUP3IEeeCf4nNnJvFjj1nR8Tuz+m77Lj+P20S3GmMI sIFwmRCixl00l2EgStY7IRXBQ3MW26Fg5+FjA8uYUCiGLTnotKaBGTTho10eC/TtneTt 4oGEW/oyjHb5d02c3XAgnJYCRsBcgX5LcTLYms1yjvNgiCCRhFWWnj03YMYf1IpFg9Xb 2pUVw9RUG9idZX2cs2rYBXtwcMx/4NJyVAkpdyA7Nc0pJH4/xBox9xIfZFG+CDclKk3T 5qLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lP4IG4mDY9DgV+tOoDW146wl3lit/aOFC7RSHZ9QL6c=; b=aAI/0Uc6rzG4mpn/wcdXoT2YnIE5uVIMLJlA+9GDphe6Yh4qTaoKC3ZnjtxjZkOy8C 4lFH1wWsl2Y9Yc3qwVlMliOHTGKDCV1P11Cd/gDbpMeZoDAH7Fxmm6d+HKsaGCdqIGSq peJ3CP8NtXOvM+XXf3KVho5+AzNzr0LRee8VuagbEO8TTPqOpmlHmYkmJAOsWgh4Ip2m ydHyfY/zCRs0kEw8yimP8NNQbzQpjz1ISeBjiokZCFK1EnjZcvL4jwY7el0GogxOMyVc 6KhNtMWEV5Ldw+J0AsbFkeb5ecKgEreJqX3EP5BcoBaBnVCtMBlN3WotF5+uvcBwRyWP 05jw== X-Gm-Message-State: APt69E3Lni98y2u0CftrIjjkDi7hnSlMi+yLGN7/KU3oRubolNVFqR7l /l8sNvRynpzPjMso927K+D0kIw== X-Google-Smtp-Source: AAOMgpdE64+1zV7GJaXTBdEg3SRPrxLh8GJ+isMaAZUmLxh0Y2PhJsD7c0Q5SUzLmZ6eAx22p8Osvg== X-Received: by 2002:a62:ae08:: with SMTP id q8-v6mr19171813pff.126.1530404400761; Sat, 30 Jun 2018 17:20:00 -0700 (PDT) Received: from hobbes.alyptik.lan ([2605:e000:1117:c002:2e0:1bff:fe70:ea]) by smtp.gmail.com with ESMTPSA id b123-v6sm8424566pfb.156.2018.06.30.17.19.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Jun 2018 17:20:00 -0700 (PDT) From: Joey Pabalinas To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Daniel Martin Subject: [PATCH 3/4] HID: multitouch: drop reports containing invalid values Date: Sat, 30 Jun 2018 14:19:52 -1000 Message-Id: <29ad484c1b357fd7fd670a6f252d097677b808f8.1530402641.git.joeypabalinas@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -694,10 +694,19 @@ static void mt_complete_slot(struct mt_device *td, struct input_dev *input) { if ((td->mtclass.quirks & MT_QUIRK_CONTACT_CNT_ACCURATE) && td->num_received >= td->num_expected) return; + /* drop invalid values after counting them */ + if (td->curdata.x == 0xffff && + td->curdata.y == 0xffff && + td->curdata.w == 0xffff && + td->curdata.h == 0xffff) { + td->num_received++; + return; + } + if (td->curvalid || (td->mtclass.quirks & MT_QUIRK_ALWAYS_VALID)) { int active; int slotnum = mt_compute_slot(td, input); struct mt_slot *s = &td->curdata; struct input_mt *mt = input->mt; -- 2.18.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28D2C46464 for ; Thu, 9 Aug 2018 23:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A227223A4 for ; Thu, 9 Aug 2018 23:39:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I9o6g6lU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A227223A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbeHJCGq (ORCPT ); Thu, 9 Aug 2018 22:06:46 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41526 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbeHJCGn (ORCPT ); Thu, 9 Aug 2018 22:06:43 -0400 Received: by mail-pg1-f193.google.com with SMTP id z8-v6so3470555pgu.8; Thu, 09 Aug 2018 16:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lP4IG4mDY9DgV+tOoDW146wl3lit/aOFC7RSHZ9QL6c=; b=I9o6g6lUQirlFbkAQrk5QUCbYQsxxNELC68PBska0J7Zxyeoecx7YB9lCISpdahvEr KFE0Ie2oqiNvHDHaVuQQbQ3pjQrhFyx3xyLu05kB5vr6I++4JrbfmikKuUXGNIObznZR aY/IMF55CcgkpDCkSQ2HZHjn+mD3S65kOrtjZE8Sts+uTVPVP4yjN8eF68B5L/ImHs9v vStwno+cpctWBQPC/oeNc2DHHnWQ504zISyjANXRbhUUbuZxM3cRJ2uan24q98y/9g9e PvFihbFcXsANBEqnq6qcxeeZKhkshYwtp08LjhVT6CbcQXtQ4uC8KrDoS4xZ3hdTTSCg 8LcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lP4IG4mDY9DgV+tOoDW146wl3lit/aOFC7RSHZ9QL6c=; b=S9FW63SIyR9cC02aK+r6vuBmE3e8G8TFlLZfvQbrvSq4p7Xai7htSnLCNao1YFqwZ4 12807cM96dcrGMrn0cJxRzTDPKbw5wWrkUVLFAQbV668zObv0c1E8WfVynyupEofMXAl jDHt6XHLo62JKWSimCf6f0VvasxmMeVHjV7EKA/Bb3A8d4KacPKcYNV+EZh2lrIlMEcP 03rT9pPG0okkREuQ5e889TUfP2CPmIxLr2ugLQRNIdowoRWZdSwOT9a3jke8sIvipZ8C qvzW9jraaxaGE8O9cX/UXqTadjuy8OV399nhD5IjbbsZtAlcwOzSiRDd0CdeYPQB/w7x CXTw== X-Gm-Message-State: AOUpUlH4/OUrH+iKe7UpadJExKLnTKM/2Pnc6fQEd/cYwvsX9eWzAEfY 8BOJ6C/p2QgJUgZYxdDn6gRyBGkV X-Google-Smtp-Source: AA+uWPzjUWGrAEZ0fth4KWn22Pd3XoFOhixcF9aSqnr/fGNN7CmSySZW9w6eLZxj2DC/8WQsseHjrw== X-Received: by 2002:a63:2013:: with SMTP id g19-v6mr4014759pgg.68.1533857973591; Thu, 09 Aug 2018 16:39:33 -0700 (PDT) Received: from hobbes.alyptik.lan (cpe-98-150-136-16.hawaii.res.rr.com. [98.150.136.16]) by smtp.gmail.com with ESMTPSA id d191-v6sm14275101pfg.172.2018.08.09.16.39.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 16:39:33 -0700 (PDT) From: Joey Pabalinas To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Daniel Martin Subject: [PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values Date: Thu, 9 Aug 2018 13:39:18 -1000 Message-Id: <29ad484c1b357fd7fd670a6f252d097677b808f8.1530402641.git.joeypabalinas@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20180809233918.-kKKRctf3uzCrNNoRXrDMyXDqYk2nhbEVB1QuQzwbc8@z> Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -694,10 +694,19 @@ static void mt_complete_slot(struct mt_device *td, struct input_dev *input) { if ((td->mtclass.quirks & MT_QUIRK_CONTACT_CNT_ACCURATE) && td->num_received >= td->num_expected) return; + /* drop invalid values after counting them */ + if (td->curdata.x == 0xffff && + td->curdata.y == 0xffff && + td->curdata.w == 0xffff && + td->curdata.h == 0xffff) { + td->num_received++; + return; + } + if (td->curvalid || (td->mtclass.quirks & MT_QUIRK_ALWAYS_VALID)) { int active; int slotnum = mt_compute_slot(td, input); struct mt_slot *s = &td->curdata; struct input_mt *mt = input->mt; -- 2.18.0