From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1193EC432C3 for ; Fri, 15 Nov 2019 07:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB86A2073C for ; Fri, 15 Nov 2019 07:54:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Tj7gXOnq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727274AbfKOHy2 (ORCPT ); Fri, 15 Nov 2019 02:54:28 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41282 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOHy2 (ORCPT ); Fri, 15 Nov 2019 02:54:28 -0500 Received: by mail-lj1-f193.google.com with SMTP id m4so4709126ljj.8 for ; Thu, 14 Nov 2019 23:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=Tj7gXOnqtuG0wJhNZbvfhuhFF7Ajj+d/fkSs7BOhJuk6zYcUK3pqsPz4KlpJ5C6cZu CQ9MRWf2wM06ny9O2bnOKcTBNvY1ewmlHc0/L/nIx34DK3gZJOIMBOt6MJMcRJUnM6lj Sty8aREsnWc3bR9ednCLj5/uDLng1EyPh4j+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=cmZJCqNYcTzym+COH4b79ihO3F15GfDOypfUk/ul4N/IrGTeVDcIFicJum2bS/TzE4 nUcgahRGLGcfapi86aBW+tUTrAWJqalfW5rIL4/lSOoU99wX9wZwGTvHY0s4ind9TfYn 7G0upAQJJI4Ft8WYlWXDNt95E7KWynZRSFaBjngoAlHGr25aOFp5hrytb7i/a784vq7J JBpMEhiN7/KfEa5OZU4UhI9DYlfIPTUhN3AQhlBrQqwHAaMZgcH9Xgq6AIYfR5aHvcxr xExOMe7IWNMXJAWFiyvHBiw242uuTxGQOj/vIsaYWIXsL94hr8RXi8ExRb05v6d+e2+z uO7w== X-Gm-Message-State: APjAAAUqx/1YtbFIWvqtAxuoaly1RY1WTnoHEHBDxLqpVlt9tvq0w5Jc gDqgWsQX8XcXQmKrwrfCj/68Ig== X-Google-Smtp-Source: APXvYqwtca4V1MXOZa/BxeDe/jqUfjT4UHa/rribPRAykBqSAV8Y1dWumBHX7aG8dBwq5CyNgx3uLQ== X-Received: by 2002:a2e:8809:: with SMTP id x9mr9979158ljh.82.1573804466324; Thu, 14 Nov 2019 23:54:26 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id w11sm4254332lji.45.2019.11.14.23.54.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 23:54:25 -0800 (PST) Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang , Timur Tabi Cc: Qiang Zhao , Christophe Leroy , linuxppc-dev , linux-arm-kernel , lkml , Scott Wood , netdev References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <29b45e76-f384-fe16-0891-cc51cfecefd4@rasmusvillemoes.dk> Date: Fri, 15 Nov 2019 08:54:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/2019 06.44, Li Yang wrote: > On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: >> >> On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes >> wrote: >>> >>> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not >>> change anything. In order to allow removing the PPC32 dependency from >>> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit >>> dependency. >> >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? It's not that "we" don't want to allow building this on non-PPC per se, but making it build requires some surgery that I think should be done by whoever might eventually want it. So _my_ reason for lowering this dependency from QUICC_ENGINE to UCC_GETH is exactly what it says above. > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. Well, that kind of thing is impossible to know for outsiders like me. Maybe one can amend the commit log with that info: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." Rasmus