linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
	"kuninori.morimoto.gx@renesas.com"
	<kuninori.morimoto.gx@renesas.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yang.jie@linux.intel.com" <yang.jie@linux.intel.com>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"liam.r.girdwood@linux.intel.com"
	<liam.r.girdwood@linux.intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support
Date: Mon, 9 Sep 2019 12:53:23 -0500	[thread overview]
Message-ID: <29b9fd4e-3d78-b4a3-e61a-c066bf24995a@linux.intel.com> (raw)
In-Reply-To: <CF33C36214C39B4496568E5578BE70C7402C9EA2@PGSMSX108.gar.corp.intel.com>

Please don't top-post on public mailing lists.

> We are working on a backport 3.14 branch for Chrome projects based on BDW platform. In the branch 4-channel capture is supported on some platforms but not all. So we need to add a constraint in the machine driver for machines don't support this feature.
> 
> I checked the for-next branch in the broonie repo. The channels_max of HSW_PCM_DAI_ID_SYSTEM is 4 for capture stream so I think it would have same issue like google's backport tree. I didn't find any constraint for this dai. Would you point out where it is?
> 
> 		.capture = {
> 			.stream_name = "Analog Capture",
> 			.channels_min = 2,
> 			.channels_max = 4,
> 			.rates = SNDRV_PCM_RATE_48000,
> 			.formats = SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE,
> 		},

ok, I missed this capture case indeed, but when I look at the Chrome 
3.14 code I don't see this constraint being added, and we already have 
an ssp0_fixup function where 2 channels only are used.

	/* The ADSP will covert the FE rate to 48k, stereo */
	rate->min = rate->max = 48000;
	channels->min = channels->max = 2;

I also don't see any case where we support 4 channels in any broadwell 
machine driver?

So again can you point me to an issue or existing backport that requires 
the patch below. Not trying to be obtuse but we should only change older 
platforms when there is evidence that a change is needed.

-Pierre

> 
> Regards,
> Brent Lu
> 
> -----Original Message-----
> From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com]
> Sent: Friday, September 6, 2019 10:21 PM
> To: Lu, Brent <brent.lu@intel.com>; alsa-devel@alsa-project.org
> Cc: Rojewski, Cezary <cezary.rojewski@intel.com>; liam.r.girdwood@linux.intel.com; yang.jie@linux.intel.com; broonie@kernel.org; perex@perex.cz; tiwai@suse.com; kuninori.morimoto.gx@renesas.com; tglx@linutronix.de; linux-kernel@vger.kernel.org
> Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support
> 
> On 9/5/19 8:24 PM, Brent Lu wrote:
>> BDW boards using this machine driver supports only stereo capture and
>> playback. Implement a constraint to enforce it.
> 
> Humm, can you clarify what problem/error this patch fixes?
> 
> There are already constraints on the hsw_dais[] where the channels are stereo only.
> 
> Thanks
> -Pierre
> 
>>
>> Signed-off-by: Brent Lu <brent.lu@intel.com>
>> ---
>>    sound/soc/intel/boards/bdw-rt5677.c | 33 +++++++++++++++++++++++++++++++++
>>    1 file changed, 33 insertions(+)
>>
>> diff --git a/sound/soc/intel/boards/bdw-rt5677.c
>> b/sound/soc/intel/boards/bdw-rt5677.c
>> index 4a4d335..a312b55 100644
>> --- a/sound/soc/intel/boards/bdw-rt5677.c
>> +++ b/sound/soc/intel/boards/bdw-rt5677.c
>> @@ -22,6 +22,8 @@
>>    
>>    #include "../../codecs/rt5677.h"
>>    
>> +#define DUAL_CHANNEL 2
>> +
>>    struct bdw_rt5677_priv {
>>    	struct gpio_desc *gpio_hp_en;
>>    	struct snd_soc_component *component; @@ -245,6 +247,36 @@ static
>> int bdw_rt5677_init(struct snd_soc_pcm_runtime *rtd)
>>    	return 0;
>>    }
>>    
>> +static const unsigned int channels[] = {
>> +	DUAL_CHANNEL,
>> +};
>> +
>> +static const struct snd_pcm_hw_constraint_list constraints_channels = {
>> +	.count = ARRAY_SIZE(channels),
>> +	.list = channels,
>> +	.mask = 0,
>> +};
>> +
>> +static int bdw_fe_startup(struct snd_pcm_substream *substream) {
>> +	struct snd_pcm_runtime *runtime = substream->runtime;
>> +
>> +	/*
>> +	 * On this platform for PCM device we support,
>> +	 * stereo
>> +	 */
>> +
>> +	runtime->hw.channels_max = DUAL_CHANNEL;
>> +	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
>> +					   &constraints_channels);
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct snd_soc_ops bdw_rt5677_fe_ops = {
>> +	.startup = bdw_fe_startup,
>> +};
>> +
>>    /* broadwell digital audio interface glue - connects codec <--> CPU */
>>    SND_SOC_DAILINK_DEF(dummy,
>>    	DAILINK_COMP_ARRAY(COMP_DUMMY()));
>> @@ -273,6 +305,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = {
>>    		},
>>    		.dpcm_capture = 1,
>>    		.dpcm_playback = 1,
>> +		.ops = &bdw_rt5677_fe_ops,
>>    		SND_SOC_DAILINK_REG(fe, dummy, platform),
>>    	},
>>    
>>
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2019-09-09 17:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  1:24 Brent Lu
2019-09-06 14:20 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-09  6:34   ` Lu, Brent
2019-09-09 17:53     ` Pierre-Louis Bossart [this message]
2019-09-10  8:28       ` Lu, Brent
2019-09-10 14:12         ` Pierre-Louis Bossart
2019-09-12  6:00           ` Lu, Brent
2019-09-12 13:06             ` Pierre-Louis Bossart
2019-09-27 12:34               ` Lu, Brent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29b9fd4e-3d78-b4a3-e61a-c066bf24995a@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    --subject='Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).