From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
<architt@codeaurora.org>, <a.hajda@samsung.com>,
<Laurent.pinchart@ideasonboard.com>, <airlied@linux.ie>,
<horms@verge.net.au>, <magnus.damm@gmail.com>,
<geert@linux-m68k.org>, <niklas.soderlund@ragnatech.se>,
<sergei.shtylyov@cogentembedded.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-renesas-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder
Date: Thu, 19 Apr 2018 12:44:32 +0300 [thread overview]
Message-ID: <29caaf6f-1783-9b01-5304-8748398d41c6@mentor.com> (raw)
In-Reply-To: <1523357590-3841-2-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo, Laurent,
On 04/10/2018 01:53 PM, Jacopo Mondi wrote:
> Document Thine THC63LVD1024 LVDS decoder device tree bindings.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> ---
> .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt
> new file mode 100644
> index 0000000..0b23e70
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt
> @@ -0,0 +1,60 @@
> +Thine Electronics THC63LVD1024 LVDS decoder
> +-------------------------------------------
> +
> +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams
> +to parallel data outputs. The chip supports single/dual input/output modes,
> +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs.
> +
> +Single or dual operation mode, output data mapping and DDR output modes are
> +configured through input signals and the chip does not expose any control bus.
> +
> +Required properties:
> +- compatible: Shall be "thine,thc63lvd1024"
> +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input,
> + PPL and digital circuitry
> +
> +Optional properties:
> +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low
Thank you for the change.
I would suggest to rename 'pwdn-gpios' property of THC63LVDM83D as well,
as far as I understand it is only described in DT bindings documentation,
and the property is unused in the driver or board DTS files at the moment.
> +- oe-gpios: Output enable GPIO signal, pin name "OE". Active high
Okay :)
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2018-04-19 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 10:53 [PATCH v8 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge Jacopo Mondi
2018-04-10 10:53 ` [PATCH v8 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Jacopo Mondi
2018-04-13 21:12 ` Rob Herring
2018-04-19 9:44 ` Vladimir Zapolskiy [this message]
2018-04-19 9:48 ` Vladimir Zapolskiy
2018-04-19 10:10 ` Vladimir Zapolskiy
2018-04-19 10:32 ` jacopo mondi
2018-04-10 10:53 ` [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver Jacopo Mondi
2018-04-13 16:28 ` jacopo mondi
2018-04-19 11:18 ` Vladimir Zapolskiy
2018-04-19 12:33 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29caaf6f-1783-9b01-5304-8748398d41c6@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).