From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752177AbdG1Opc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Jul 2017 10:45:32 -0400
Received: from mail-pf0-f179.google.com ([209.85.192.179]:36294 "EHLO
        mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752070AbdG1OpC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Jul 2017 10:45:02 -0400
Reply-To: minyard@acm.org
Subject: Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()
From: Corey Minyard <minyard@acm.org>
To: Fabian Frederick <fabf@skynet.be>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net
References: <20170130184755.18569-1-fabf@skynet.be>
 <b5ee1292-00ff-6579-7e51-ce5d9de21b58@acm.org>
Message-ID: <29e3f415-bdf3-05b0-e443-af84155022c1@acm.org>
Date: Fri, 28 Jul 2017 09:44:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <b5ee1292-00ff-6579-7e51-ce5d9de21b58@acm.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/28/2017 09:27 AM, Corey Minyard wrote:
> I missed this until now, and I see it hasn't been applied yet.  It's 
> queued for the next release.
>

Well, never mind, I see the main update didn't go in.

-corey

> Thanks,
>
> -corey
>
> On 01/30/2017 12:47 PM, Fabian Frederick wrote:
>> instead of atomic_add_unless(value, -1, 0)
>>
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>> ---
>>   drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_msghandler.c 
>> b/drivers/char/ipmi/ipmi_msghandler.c
>> index 9f69995..961d677 100644
>> --- a/drivers/char/ipmi/ipmi_msghandler.c
>> +++ b/drivers/char/ipmi/ipmi_msghandler.c
>> @@ -3851,7 +3851,7 @@ static void handle_new_recv_msgs(ipmi_smi_t intf)
>>        * If the pretimout count is non-zero, decrement one from it and
>>        * deliver pretimeouts to all the users.
>>        */
>> -    if (atomic_add_unless(&intf->watchdog_pretimeouts_to_deliver, 
>> -1, 0)) {
>> +    if (atomic_dec_not_zero(&intf->watchdog_pretimeouts_to_deliver)) {
>>           ipmi_user_t user;
>>             rcu_read_lock();
>
>