From: liulongfang <liulongfang@huawei.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
<wangzhou1@hisilicon.com>, "Zaibo Xu" <xuzaibo@huawei.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error
Date: Sun, 7 Feb 2021 17:49:03 +0800 [thread overview]
Message-ID: <29e527d9-5b0e-5054-b0b4-d8b72e1c917c@huawei.com> (raw)
In-Reply-To: <CAMj1kXF71nPwMVNM-xwo2UNXW6xq3G=QTCNahLNS7fCfhdSMsA@mail.gmail.com>
On 2021/2/7 16:02, Ard Biesheuvel wrote:
> On Sun, 7 Feb 2021 at 03:47, liulongfang <liulongfang@huawei.com> wrote:
>>
>> On 2021/2/5 19:44, Herbert Xu write:
>>> On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote:
>>>> If this configuration item is not turned on,
>>>> the allocation of crypto_tfm will fail when
>>>> the shash algorithm calculates the hash
>>>> through the software.
>>>>
>>>> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
>>>> ---
>>>> arch/arm64/configs/defconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>> index 8383016..7cfc9b6 100644
>>>> --- a/arch/arm64/configs/defconfig
>>>> +++ b/arch/arm64/configs/defconfig
>>>> @@ -117,7 +117,7 @@ CONFIG_KVM=y
>>>> CONFIG_ARM64_CRYPTO=y
>>>> CONFIG_CRYPTO_SHA1_ARM64_CE=y
>>>> CONFIG_CRYPTO_SHA2_ARM64_CE=y
>>>> -CONFIG_CRYPTO_SHA512_ARM64_CE=m
>>>> +CONFIG_CRYPTO_SHA512_ARM64_CE=y
>>>
>>> If this is truly needed then it should be enabled through Kconfig.
>>>
>>> Cheers,
>>>
>> Hi Herbert,
>> The option select CRYPTO_SHA512 already exists in Kconfig.
>
> In that case, how can the shash TFM allocation fail?
>
Hi
After comparison and investigation, the problem is that the header
file "crypto/internal/hash.h" is not added. After adding this header file,
which CRYPTO_SHA512_ARM64_C compilation option does not need to be enabled.
I will modify it in the next patch.
>> Can I change it to this: select CRYPTO_SHA512 || CRYPTO_SHA512_ARM64_CE
>
> No, you cannot select expressions like that.
>
> Could you please explain the problem you are trying to solve?
> .
>
When allocation shash TFM with hmac(sha512)-cbc(aes) algorithm,
TFM will return an error.
Thanks
Longfang.
next prev parent reply other threads:[~2021-02-07 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:10 [PATCH 0/3] crypto:hisilicon/sec - fixes some coding style Longfang Liu
2021-02-05 10:10 ` [PATCH 1/3] crypto: hisilicon/sec - fixes some log printing style Longfang Liu
2021-02-05 10:10 ` [PATCH 2/3] crypto: hisilicon/sec - fixes some driver coding style Longfang Liu
2021-02-05 10:10 ` [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error Longfang Liu
2021-02-05 11:44 ` Herbert Xu
2021-02-07 2:46 ` liulongfang
2021-02-07 8:02 ` Ard Biesheuvel
2021-02-07 9:49 ` liulongfang [this message]
2021-02-20 9:51 ` liulongfang
2021-03-04 4:41 ` Herbert Xu
2021-03-04 5:56 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e527d9-5b0e-5054-b0b4-d8b72e1c917c@huawei.com \
--to=liulongfang@huawei.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).