From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1190DC432C1 for ; Tue, 24 Sep 2019 10:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8207214D9 for ; Tue, 24 Sep 2019 10:34:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="QN0xTkk5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409497AbfIXKe0 (ORCPT ); Tue, 24 Sep 2019 06:34:26 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:44092 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409465AbfIXKeZ (ORCPT ); Tue, 24 Sep 2019 06:34:25 -0400 Received: by mail-pf1-f193.google.com with SMTP id q21so1073762pfn.11 for ; Tue, 24 Sep 2019 03:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3y++5MWe+nfLT59J4EFQaaYthSHGH3KQ5ez/42aOPdc=; b=QN0xTkk5/nR8L2agLUEjaJWbrf1cK1vvJFl4PJiojL+cuYVlgsVfnXG9d2rVjhlKIX kpiy7ClqUnrTSZe1w4XugAmftdG6mzzopfjOs0WmwB1byRgHEIZZ2z2cQmsFxw4zqUG/ J3xgCKktDwgCvDrh0OQuDt5FNYzZBsuyj2cdEc4ydpJ7I+XLyhnwFiFiGeTcYFrV/2JV 0EbxhHZDLXxNSSW3jXfooDs3rnoy8DRw7+ieGGTFI2tBg96RkNukUj7vtwh1Nl410joB phAtzN6ScbyicCsjP5w3+Tb0hLsmkJZI2TeNjxCMAP6zEYs0w9Ym00sdaT1/cg6BhwBQ VUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3y++5MWe+nfLT59J4EFQaaYthSHGH3KQ5ez/42aOPdc=; b=q3IA4zPy3/jjGNlwm1qYeCo2QJd4pDqBG7CiD0Ymwrv56w96dstJf6t3qcSnhQ/dlo MsjuLZHrk6YGkqI+Pg85etBoC5roe3LnMSha4sHfXOpB5qzZ2iWQyDDWtUneggxfgao3 a+rcVEb1APBCWWGnbKTYL5vUfXL9ypeNBx0NVzmJuTWv7/21WOu+M3+9S2abI04Odzgk e279VfXfb1y0EEp37Ih90oE1cwAqlyW1zBKmlvV8dhUhbMCUcFYhSfK7RWItUcTybA7S Cgln8Cpq6naNMDwGikrSVou8HhvcMllt7UWZKIoVK69WZOse9LGOSR0g6bgzgDu3gLAe KNkg== X-Gm-Message-State: APjAAAXs7L3SVREy5jgjDXPXkthJ/k3ndYmWdht3AxS9R56ACtqe6IfQ IxUd0dECYGk8TZNmfHXuz5eSpxfBKcg8AfhG X-Google-Smtp-Source: APXvYqwM9nLMf57gHat2qR6cvPByEWl6hqrFgd7GudTP9BsEhIq/NHvJGBJVCRtDZNDyLjyEC3o+Pw== X-Received: by 2002:a63:67c2:: with SMTP id b185mr2384022pgc.436.1569321264430; Tue, 24 Sep 2019 03:34:24 -0700 (PDT) Received: from ?IPv6:2600:380:8419:743e:a9a6:f93b:f300:79e6? ([2600:380:8419:743e:a9a6:f93b:f300:79e6]) by smtp.gmail.com with ESMTPSA id m2sm2387410pff.154.2019.09.24.03.34.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 03:34:23 -0700 (PDT) Subject: Re: [PATCH v2 0/2] Optimise io_uring completion waiting From: Jens Axboe To: Peter Zijlstra Cc: Pavel Begunkov , Ingo Molnar , Ingo Molnar , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190923083549.GA42487@gmail.com> <731b2087-7786-5374-68ff-8cba42f0cd68@kernel.dk> <759b9b48-1de3-1d43-3e39-9c530bfffaa0@kernel.dk> <43244626-9cfd-0c0b-e7a1-878363712ef3@gmail.com> <20190924094942.GN2349@hirez.programming.kicks-ass.net> <6f935fb9-6ebd-1df1-0cd0-69e34a16fa7e@kernel.dk> Message-ID: <29e6e06e-351f-c19d-ed7c-51f30c9ca887@kernel.dk> Date: Tue, 24 Sep 2019 12:34:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <6f935fb9-6ebd-1df1-0cd0-69e34a16fa7e@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/24/19 4:13 AM, Jens Axboe wrote: > On 9/24/19 3:49 AM, Peter Zijlstra wrote: >> On Tue, Sep 24, 2019 at 10:36:28AM +0200, Jens Axboe wrote: >> >>> +struct io_wait_queue { >>> + struct wait_queue_entry wq; >>> + struct io_ring_ctx *ctx; >>> + struct task_struct *task; >> >> wq.private is where the normal waitqueue stores the task pointer. >> >> (I'm going to rename that) > > If you do that, then we can just base the io_uring parts on that. Just took a quick look at it, and ran into block/kyber-iosched.c that actually uses the private pointer for something that isn't a task struct... -- Jens Axboe