From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Arnd Bergmann <arnd@arndb.de>,
soc@kernel.org, Rob Herring <robh@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: synaptics: add DT for AS370-RDK
Date: Fri, 20 Aug 2021 11:59:30 +0200 [thread overview]
Message-ID: <29e96ece-8541-a7a2-c6a9-453be6644eed@canonical.com> (raw)
In-Reply-To: <20210820173108.01d5c6de@xhacker.debian>
On 20/08/2021 11:31, Jisheng Zhang wrote:
> Add a basic support for AS370-RDK board based on the AS370 SoC. We can
> get a basic shell on the uart console now.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> Hi Arnd,
>
> If it's too late, I will add it in a PR for 5.16 in next development window.
>
> Thanks
>
> arch/arm64/boot/dts/synaptics/Makefile | 1 +
> arch/arm64/boot/dts/synaptics/as370-rdk.dts | 29 +++++++++++++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 arch/arm64/boot/dts/synaptics/as370-rdk.dts
>
> diff --git a/arch/arm64/boot/dts/synaptics/Makefile b/arch/arm64/boot/dts/synaptics/Makefile
> index de71ddda6835..c1c4f6c040b3 100644
> --- a/arch/arm64/boot/dts/synaptics/Makefile
> +++ b/arch/arm64/boot/dts/synaptics/Makefile
> @@ -1,4 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> # Berlin SoC Family
> +dtb-$(CONFIG_ARCH_BERLIN) += as370-rdk.dtb
> dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb
> dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb
> diff --git a/arch/arm64/boot/dts/synaptics/as370-rdk.dts b/arch/arm64/boot/dts/synaptics/as370-rdk.dts
> new file mode 100644
> index 000000000000..6f5c37c98be6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/synaptics/as370-rdk.dts
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2018-2021 Synaptics Incorporated
> + *
> + * Author: Jisheng Zhang <jszhang@kernel.org>
> + */
> +
> +/dts-v1/;
> +
> +#include "as370.dtsi"
> +
> +/ {
> + model = "Synaptics AS370 RDK";
> + compatible = "syna,as370-rdk", "syna,as370";
There is no such binding. You need to update the bindings file (first
patch in the series).
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-08-20 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 9:31 [PATCH] arm64: dts: synaptics: add DT for AS370-RDK Jisheng Zhang
2021-08-20 9:59 ` Krzysztof Kozlowski [this message]
2021-08-20 10:27 ` Jisheng Zhang
2021-08-20 19:55 ` Arnd Bergmann
2022-04-07 20:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e96ece-8541-a7a2-c6a9-453be6644eed@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).