From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64524C43441 for ; Tue, 13 Nov 2018 22:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CD5422360 for ; Tue, 13 Nov 2018 22:44:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TORR10Xi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CD5422360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731623AbeKNIpK (ORCPT ); Wed, 14 Nov 2018 03:45:10 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:36569 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbeKNIpJ (ORCPT ); Wed, 14 Nov 2018 03:45:09 -0500 Received: by mail-yb1-f196.google.com with SMTP id g192-v6so6129962ybf.3 for ; Tue, 13 Nov 2018 14:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mmrh2/ekK1GVScB29q4AyXpW7LjBjVHfaiaSHTgyJ2w=; b=TORR10XiswDDYFvut14qLcAfYuOl9Tuoztqk0p2v6P/A4zkDxOg2T6EEexjdD1O84U Qsyot/QolGxybub92XL7kYlZ4wYIQk8+7jQ4kFT3U9ANU6h4sviogWbqGChXtmKM6Vat I91tk3y8a1/jeAEcumNInQvtHYQ5pPt/iimVvFvmBXC7NHVY/NC/hvQ+qQt18yPRqtuo cpTfNBjCmbcpsc19jeY+J07yOHiaSImKpVae3zwvXP7DW7+JTeox46SEsNAYIdcXNrVC cse8ygItOqxqHnyYMw+UQwLYi7KwOzj/LrKzZKjOuo0m76VRcWcwf5efMksN90wypXIY xuMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mmrh2/ekK1GVScB29q4AyXpW7LjBjVHfaiaSHTgyJ2w=; b=haNr4s8BDZcQ6zFuOwSNuct8i2/dXID61YNKDTSVPuL4johuk37saUFCPrBlFwTCDu 4CVErOlXL4TMxZg5AwiuTL9gU0tTn+J2G47sUgHFhjKjy1LOCPbVbxLgt8tGLrq2c561 vK355bY6DGrUC9Y5T09DUIkVi9n3MUa/R5q4xeWcqWovgysuDXqoeX418Zmf+rPVZVAH aBqORvIGv2NSpqyaiQPF3LnyV91G9Blw78vWIhihlSbwhh5+YXoxuyr8V7lVuVWn/sH0 quyOZmy5QIUVq0Y+fj8zK3ZRXaRkl6DPyuzkgtFuMeY75c0T+PB3TDdAQSXBfnJmGoUB ZNGg== X-Gm-Message-State: AGRZ1gLHpBKrLMsTKInbEBXZT+POh+youxG4w22JEzVOiVBRE6gowhxY CRYkYttHOQrPzbasJitoAu0= X-Google-Smtp-Source: AJdET5dHwxTR9lf8aYNDVWBbLLPwjCjXJZ1PgcuDYxehFVNCma3TspLvtPEWkz7gMqdTQ8jJ2/cpYg== X-Received: by 2002:a5b:4d1:: with SMTP id u17-v6mr7007353ybp.15.1542149089386; Tue, 13 Nov 2018 14:44:49 -0800 (PST) Received: from [10.67.49.62] (igp-prod-emp-gw.broadcom.com. [192.19.223.250]) by smtp.googlemail.com with ESMTPSA id f1-v6sm7272989ywb.89.2018.11.13.14.44.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 14:44:48 -0800 (PST) Subject: Re: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page To: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kim Phillips , Greg Kroah-Hartman , Thomas Gleixner , Ravi Bangoria , Thomas Richter , rmk+kernel@armlinux.org.uk, l.stach@pengutronix.de References: <20181025175508.6967-1-f.fainelli@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <29ea3732-0018-42ff-da09-646ee71a61cb@gmail.com> Date: Tue, 13 Nov 2018 14:44:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181025175508.6967-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/18 10:55 AM, Florian Fainelli wrote: > Hi all, > > I just painfully learned that perf would segfault when > CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of > it. This patch series adds an ARM test for that by leveraging the > existing find_vdso_map() function and making it more generic and capable > of location any map within /proc/self/maps. Did not get much feedback, you are all probably busy attending LPC conferences, but I was wondering if this did make sense or if there is a better approach that should be looked at? I am starting to see additional tests failing that require some ARM (32-bit) specific changes, and not accumulating too many of these fixes on top of that series would be neat. Thank you! > > Changes in v2: > > - use strlen() instead of sizeof() -1 since we made the page name a > parameter > - use TEST_OK/TEST_FAIL in lieu of 0/-1 > - added an error message indicating CONFIG_KUSER_HELPERS might be > disabled > > Florian Fainelli (2): > perf tools: Make find_vdso_map() more modular > perf tests: Add a test for the ARM 32-bit [vectors] page > > tools/perf/arch/arm/tests/Build | 1 + > tools/perf/arch/arm/tests/arch-tests.c | 4 +++ > tools/perf/arch/arm/tests/vectors-page.c | 24 ++++++++++++++++++ > tools/perf/tests/tests.h | 5 ++++ > tools/perf/util/find-map.c | 31 ++++++++++++++++++++++++ > tools/perf/util/find-vdso-map.c | 30 +++-------------------- > 6 files changed, 68 insertions(+), 27 deletions(-) > create mode 100644 tools/perf/arch/arm/tests/vectors-page.c > create mode 100644 tools/perf/util/find-map.c > -- Florian