From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] i40e: Remove useless DMA-32 fallback configuration
Date: Sun, 9 Jan 2022 18:30:55 +0100 [thread overview]
Message-ID: <29f3c7d1-f3ca-4a13-a9fb-7425e0941c37@wanadoo.fr> (raw)
In-Reply-To: <5549ec8837b3a6fab83e92c5206cc100ffd23d85.1641748468.git.christophe.jaillet@wanadoo.fr>
Le 09/01/2022 à 18:14, Christophe JAILLET a écrit :
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to be
> 1.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lkml.org/lkml/2021/6/7/398
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++++++---------------
> 1 file changed, 7 insertions(+), 15 deletions(-)
NAK, wrong subject
CJ
next prev parent reply other threads:[~2022-01-09 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 17:14 [PATCH] i40e: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-09 17:30 ` Christophe JAILLET [this message]
2022-01-13 17:50 ` [Intel-wired-lan] " G, GurucharanX
2022-01-13 18:33 ` G, GurucharanX
2022-01-09 17:29 Christophe JAILLET
2022-01-14 4:08 ` G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29f3c7d1-f3ca-4a13-a9fb-7425e0941c37@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).