From: "Javier González" <jg@lightnvm.io>
To: Joe Perches <joe@perches.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] nvme: fix eui_show() print format
Date: Sat, 4 Nov 2017 12:22:20 +0100 [thread overview]
Message-ID: <2AC384A2-C792-45AF-AF11-89CBC128C527@lightnvm.io> (raw)
In-Reply-To: <1509722197.15520.17.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
> On 3 Nov 2017, at 16.16, Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2017-11-03 at 13:55 +0100, Christoph Hellwig wrote:
>> On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote:
>>> Signed-off-by: Javier González <javier@cnexlabs.com>
> []
>>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> []
>>> @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr,
>>> char *buf)
>>> {
>>> struct nvme_ns *ns = nvme_get_ns_from_dev(dev);
>>> - return sprintf(buf, "%8phd\n", ns->eui);
>>> + return sprintf(buf, "%8phD\n", ns->eui);
>>> }
>>> static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
>>
>> This looks correct. I wonder what the old code printed - does someone
>> have a device with an EUI-64 at hand to quickly cross check what we
>> did before?
>
> It uses spaces between bytes and not dashes.
>
> The code has been this way a couple years now.
>
> I think this proposal, while it might fix an
> unintentional output style, could also be an API
> and could cause user breakage if changed.
>
> Perhaps this should just become
>
> %8ph
>
> without D
That would be ok with me.
Javier.
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-04 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:02 [PATCH 0/3] nvme: small fixes reported by smatch Javier González
2017-11-03 10:02 ` [PATCH 1/3] nvme: do not check for ns on rw path Javier González
2017-11-03 12:53 ` Christoph Hellwig
2017-11-03 13:00 ` Javier González
2017-11-03 15:02 ` Keith Busch
2017-11-04 8:18 ` Christoph Hellwig
2017-11-04 15:38 ` Keith Busch
2017-11-06 9:13 ` Christoph Hellwig
2017-11-06 14:43 ` Keith Busch
2017-11-03 10:02 ` [PATCH 2/3] nvme: compare NQN string with right size Javier González
2017-11-03 12:54 ` Christoph Hellwig
2017-11-03 12:56 ` Javier González
2017-11-03 10:02 ` [PATCH 3/3] nvme: fix eui_show() print format Javier González
2017-11-03 12:55 ` Christoph Hellwig
2017-11-03 15:13 ` Keith Busch
2017-11-03 15:16 ` Joe Perches
2017-11-04 11:22 ` Javier González [this message]
2017-11-07 16:28 ` Christoph Hellwig
2017-11-07 16:36 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2AC384A2-C792-45AF-AF11-89CBC128C527@lightnvm.io \
--to=jg@lightnvm.io \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).