From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756913AbbJAVFE (ORCPT ); Thu, 1 Oct 2015 17:05:04 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:43092 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbbJAVFC convert rfc822-to-8bit (ORCPT ); Thu, 1 Oct 2015 17:05:02 -0400 From: John Youn To: "balbi@ti.com" , Marek Szyprowski CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Robert Baldyga , John Youn , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Thread-Topic: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Thread-Index: AQHQ9FaYP3YKOEIHQkSx/ekJZFApeA== Date: Thu, 1 Oct 2015 21:04:59 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC383B31@US01WEMBX2.internal.synopsys.com> References: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> <1442830572-6765-5-git-send-email-m.szyprowski@samsung.com> <20151001155018.GC4469@saruman.tx.rr.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.161.124] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/2015 8:50 AM, Felipe Balbi wrote: > On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote: >> DWC2 module on some platforms needs three additional hardware >> resources: phy controller, clock and power supply. All of them must be >> enabled/activated to properly initialize and operate. This was initially >> handled in s3c-hsotg driver, which has been converted to 'gadget' part >> of dwc2 driver. Unfortunately, not all of this code got moved to common >> platform code, what resulted in accessing DWC2 registers without >> enabling low-level hardware resources. This fails for example on Exynos >> SoCs. This patch moves all the code for managing those resources to >> common platform.c file and provides convenient wrappers for controlling >> them. >> >> Signed-off-by: Marek Szyprowski > > I just caught several build errors which this patch. I hope you can > send me a follow-up fix (which I can amend to $subject) otherwise > I'll have to drop this series > I forgot that this was initially part of a larger patch-set. Maybe that is causing issues? If this wasn't intended to go through Felipe's tree then my bad. Also, I noticed this patch causes deadlock warnings with lockdep enabled. Can you look into that also while you investigate this? Regards, John