From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbJEW0Y (ORCPT ); Mon, 5 Oct 2015 18:26:24 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:40439 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbbJEW0V convert rfc822-to-8bit (ORCPT ); Mon, 5 Oct 2015 18:26:21 -0400 From: John Youn To: Marek Szyprowski , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" CC: Robert Baldyga , John Youn , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v4 4/4] usb: dwc2: refactor common low-level hw code to platform.c Thread-Topic: [PATCH v4 4/4] usb: dwc2: refactor common low-level hw code to platform.c Thread-Index: AQHQ/OZQgkmCUJ72sEuvPnU9F5E3fw== Date: Mon, 5 Oct 2015 22:26:19 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3876E9@US01WEMBX2.internal.synopsys.com> References: <20151001155947.GD4469@saruman.tx.rr.com> <1443771918-19075-1-git-send-email-m.szyprowski@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.161.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/2015 12:45 AM, Marek Szyprowski wrote: > DWC2 module on some platforms needs three additional hardware > resources: phy controller, clock and power supply. All of them must be > enabled/activated to properly initialize and operate. This was initially > handled in s3c-hsotg driver, which has been converted to 'gadget' part > of dwc2 driver. Unfortunately, not all of this code got moved to common > platform code, what resulted in accessing DWC2 registers without > enabling low-level hardware resources. This fails for example on Exynos > SoCs. This patch moves all the code for managing those resources to > common platform.c file and provides convenient wrappers for controlling > them. > > Signed-off-by: Marek Szyprowski > --- > Changelog: > v4: > - fixed broken conditional compilation and adjusted comments in dwc2_hsotg > structure documentation > > v3: > - rebased onto latest 'testing/next' from Felipe Balbi (includes > s3c_hsotg -> dwc2 rename) > > v2: > - moved setting of ll_hw_enabled flag to enable/disable functions, > as suggested by John Youn > - moved setting of phy width to dwc2_lowlevel_init function > --- > drivers/usb/dwc2/core.h | 24 +++-- > drivers/usb/dwc2/gadget.c | 193 ++++-------------------------------- > drivers/usb/dwc2/platform.c | 234 +++++++++++++++++++++++++++++++++++++------- > 3 files changed, 228 insertions(+), 223 deletions(-) > Hi Marek, I still see lockdep warnings. Any ideas about these? [ 1618.179611] ====================================================== [ 1618.179612] [ INFO: possible circular locking dependency detected ] [ 1618.179613] 4.3.0-rc3-snps-00125-g744fd93 #28 Not tainted [ 1618.179614] ------------------------------------------------------- [ 1618.179615] modprobe/2658 is trying to acquire lock: [ 1618.179616] (&hsotg->init_mutex){+.+.+.}, at: [] dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179622] [ 1618.179622] but task is already holding lock: [ 1618.179623] (udc_lock){+.+.+.}, at: [] usb_gadget_probe_driver+0x3a/0xd0 [udc_core] [ 1618.179627] [ 1618.179627] which lock already depends on the new lock. [ 1618.179627] [ 1618.179628] [ 1618.179628] the existing dependency chain (in reverse order) is: [ 1618.179629] [ 1618.179629] -> #1 (udc_lock){+.+.+.}: [ 1618.179631] [] lock_acquire+0xdd/0x1f0 [ 1618.179635] [] mutex_lock_nested+0x76/0x3e0 [ 1618.179638] [] usb_add_gadget_udc_release+0x187/0x240 [udc_core] [ 1618.179640] [] usb_add_gadget_udc+0x10/0x20 [udc_core] [ 1618.179642] [] dwc2_gadget_init+0x47c/0x580 [dwc2] [ 1618.179645] [] dwc2_driver_probe+0x422/0x4b0 [dwc2] [ 1618.179648] [] platform_drv_probe+0x34/0x90 [ 1618.179650] [] driver_probe_device+0x224/0x480 [ 1618.179652] [] __device_attach_driver+0x71/0xa0 [ 1618.179654] [] bus_for_each_drv+0x5d/0x90 [ 1618.179655] [] __device_attach+0xbf/0x140 [ 1618.179657] [] device_initial_probe+0x13/0x20 [ 1618.179658] [] bus_probe_device+0xa3/0xb0 [ 1618.179660] [] device_add+0x40d/0x690 [ 1618.179661] [] platform_device_add+0x111/0x270 [ 1618.179663] [] dwc2_pci_probe+0xe8/0x1d2 [dwc2_pci] [ 1618.179665] [] local_pci_probe+0x45/0xa0 [ 1618.179668] [] pci_device_probe+0xe1/0x130 [ 1618.179669] [] driver_probe_device+0x224/0x480 [ 1618.179671] [] __driver_attach+0x88/0x90 [ 1618.179672] [] bus_for_each_dev+0x66/0xa0 [ 1618.179674] [] driver_attach+0x1e/0x20 [ 1618.179675] [] bus_add_driver+0x1ee/0x280 [ 1618.179677] [] driver_register+0x60/0xe0 [ 1618.179678] [] __pci_register_driver+0x60/0x70 [ 1618.179680] [] 0xffffffffc000601e [ 1618.179681] [] do_one_initcall+0xb3/0x200 [ 1618.179684] [] do_init_module+0x5f/0x1e7 [ 1618.179687] [] load_module+0x21a8/0x2840 [ 1618.179689] [] SyS_finit_module+0x9a/0xc0 [ 1618.179691] [] entry_SYSCALL_64_fastpath+0x16/0x7a [ 1618.179693] [ 1618.179693] -> #0 (&hsotg->init_mutex){+.+.+.}: [ 1618.179695] [] __lock_acquire+0x1d35/0x1db0 [ 1618.179697] [] lock_acquire+0xdd/0x1f0 [ 1618.179698] [] mutex_lock_nested+0x76/0x3e0 [ 1618.179700] [] dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179703] [] udc_bind_to_driver+0xa4/0x100 [udc_core] [ 1618.179705] [] usb_gadget_probe_driver+0x7a/0xd0 [udc_core] [ 1618.179707] [] usb_composite_probe+0xa4/0xc0 [libcomposite] [ 1618.179709] [] msg_init+0x10/0x1000 [g_mass_storage] [ 1618.179711] [] do_one_initcall+0xb3/0x200 [ 1618.179713] [] do_init_module+0x5f/0x1e7 [ 1618.179714] [] load_module+0x21a8/0x2840 [ 1618.179716] [] SyS_finit_module+0x9a/0xc0 [ 1618.179717] [] entry_SYSCALL_64_fastpath+0x16/0x7a [ 1618.179719] [ 1618.179719] other info that might help us debug this: [ 1618.179719] [ 1618.179720] Possible unsafe locking scenario: [ 1618.179720] [ 1618.179721] CPU0 CPU1 [ 1618.179722] ---- ---- [ 1618.179722] lock(udc_lock); [ 1618.179723] lock(&hsotg->init_mutex); [ 1618.179725] lock(udc_lock); [ 1618.179726] lock(&hsotg->init_mutex); [ 1618.179727] [ 1618.179727] *** DEADLOCK *** [ 1618.179727] [ 1618.179728] 1 lock held by modprobe/2658: [ 1618.179729] #0: (udc_lock){+.+.+.}, at: [] usb_gadget_probe_driver+0x3a/0xd0 [udc_core] [ 1618.179732] [ 1618.179732] stack backtrace: [ 1618.179734] CPU: 3 PID: 2658 Comm: modprobe Not tainted 4.3.0-rc3-snps-00125-g744fd93 #28 [ 1618.179735] Hardware name: ASUS All Series/H97M-PLUS, BIOS 2305 10/09/2014 [ 1618.179736] ffffffff82aa4b20 ffff880215a57a20 ffffffff813f3289 ffffffff82aa4b20 [ 1618.179738] ffff880215a57a60 ffffffff810d609c ffff880215a57ac0 ffff880213560808 [ 1618.179740] 0000000000000001 0000000000000000 ffff880213560840 ffff880213560000 [ 1618.179742] Call Trace: [ 1618.179744] [] dump_stack+0x4b/0x72 [ 1618.179746] [] print_circular_bug+0x1ec/0x260 [ 1618.179748] [] __lock_acquire+0x1d35/0x1db0 [ 1618.179749] [] ? dev_vprintk_emit+0x90/0x240 [ 1618.179752] [] ? pps_cdev_release+0x10/0x30 [pps_core] [ 1618.179754] [] lock_acquire+0xdd/0x1f0 [ 1618.179756] [] ? dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179758] [] mutex_lock_nested+0x76/0x3e0 [ 1618.179760] [] ? dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179762] [] ? __dev_printk+0x3c/0x80 [ 1618.179764] [] ? dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179767] [] dwc2_hsotg_udc_start+0x5c/0x200 [dwc2] [ 1618.179768] [] ? 0xffffffffc0474000 [ 1618.179770] [] udc_bind_to_driver+0xa4/0x100 [udc_core] [ 1618.179772] [] usb_gadget_probe_driver+0x7a/0xd0 [udc_core] [ 1618.179774] [] usb_composite_probe+0xa4/0xc0 [libcomposite] [ 1618.179776] [] msg_init+0x10/0x1000 [g_mass_storage] [ 1618.179777] [] do_one_initcall+0xb3/0x200 [ 1618.179779] [] ? rcu_read_lock_sched_held+0x6d/0x80 [ 1618.179782] [] ? kmem_cache_alloc_trace+0x1f4/0x2d0 [ 1618.179783] [] do_init_module+0x5f/0x1e7 [ 1618.179785] [] load_module+0x21a8/0x2840 [ 1618.179786] [] ? __symbol_put+0x40/0x40 [ 1618.179788] [] SyS_finit_module+0x9a/0xc0 [ 1618.179790] [] entry_SYSCALL_64_fastpath+0x16/0x7a Regards, John