linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Volkov <Andrew.Volkov@transas.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: RE: PROBLEM: possible proceses leak
Date: Mon, 8 Dec 2003 21:45:17 +0300	[thread overview]
Message-ID: <2E74F312D6980D459F3A05492BA40F8D0391B0EE@clue.transas.com> (raw)

Yes.

And same bug in kernel/sched.c in ALL *_sleep_on

Andrey

==========================================================
--- kernel/sched.c.old	2003-12-08 21:39:08.000000000 +0300
+++ kernel/sched.c	2003-12-08 21:40:19.000000000 +0300
@@ -819,10 +819,8 @@
 void interruptible_sleep_on(wait_queue_head_t *q)
 {
 	SLEEP_ON_VAR
-
-	current->state = TASK_INTERRUPTIBLE;
-
 	SLEEP_ON_HEAD
+	current->state = TASK_INTERRUPTIBLE;
 	schedule();
 	SLEEP_ON_TAIL
 }
@@ -831,9 +829,8 @@
 {
 	SLEEP_ON_VAR
 
-	current->state = TASK_INTERRUPTIBLE;
-
 	SLEEP_ON_HEAD
+	current->state = TASK_INTERRUPTIBLE;
 	timeout = schedule_timeout(timeout);
 	SLEEP_ON_TAIL
 
@@ -844,9 +841,8 @@
 {
 	SLEEP_ON_VAR
 	
-	current->state = TASK_UNINTERRUPTIBLE;
-
 	SLEEP_ON_HEAD
+	current->state = TASK_UNINTERRUPTIBLE;
 	schedule();
 	SLEEP_ON_TAIL
 }
@@ -855,9 +851,8 @@
 {
 	SLEEP_ON_VAR
 	
-	current->state = TASK_UNINTERRUPTIBLE;
-
 	SLEEP_ON_HEAD
+	current->state = TASK_UNINTERRUPTIBLE;
 	timeout = schedule_timeout(timeout);
 	SLEEP_ON_TAIL
 

             reply	other threads:[~2003-12-08 18:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-08 18:45 Andrew Volkov [this message]
2003-12-08 18:51 ` PROBLEM: possible proceses leak William Lee Irwin III
2003-12-08 19:09   ` Linus Torvalds
2003-12-08 19:23     ` William Lee Irwin III
  -- strict thread matches above, loose matches on Subject: below --
2003-12-08 19:34 Andrew Volkov
2003-12-08 18:01 Andrew Volkov
2003-12-08 18:25 ` William Lee Irwin III
2003-12-08 19:08 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2E74F312D6980D459F3A05492BA40F8D0391B0EE@clue.transas.com \
    --to=andrew.volkov@transas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).