From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: "djkurtz@chromium.org" <djkurtz@chromium.org>,
"Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Jaroslav Kysela <perex@perex.cz>, "Takashi Iwai" <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems
Date: Fri, 4 May 2018 09:15:42 +0000 [thread overview]
Message-ID: <2E89032DDAA8B9408CB92943514A0337014C1EA102@SW-EX-MBX01.diasemi.com> (raw)
In-Reply-To: <1525334313-28661-1-git-send-email-akshu.agrawal@amd.com>
On 03 May 2018 08:59, Akshu Agrawal wrote:
> Non-dts based systems can use ACPI DSDT to pass on the mclk
> to da7219.
> This enables da7219 mclk to be linked to system clock.
> Enable/Disable of the mclk is already handled in the codec so
> platform drivers don't have to explicitly do handling of mclk.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
> ---
> v2: Fixed kbuild error
> v3: Add corresponding clk_put for clk_get
> include/sound/da7219.h | 2 ++
> sound/soc/codecs/da7219.c | 10 +++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/sound/da7219.h b/include/sound/da7219.h
> index 1bfcb16..df7ddf4 100644
> --- a/include/sound/da7219.h
> +++ b/include/sound/da7219.h
> @@ -38,6 +38,8 @@ struct da7219_pdata {
>
> const char *dai_clks_name;
>
> + const char *mclk_name;
> +
> /* Mic */
> enum da7219_micbias_voltage micbias_lvl;
> enum da7219_mic_amp_in_sel mic_amp_in_sel;
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index 980a6a8..ecd46fc 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -1624,6 +1624,8 @@ static struct da7219_pdata *da7219_fw_to_pdata(struct
> snd_soc_component *compone
> dev_warn(dev, "Using default clk name: %s\n",
> pdata->dai_clks_name);
>
> + device_property_read_string(dev, "dlg,mclk-name", &pdata->mclk_name);
> +
Personally am still not keen on this. To me the use of a device_property_*
function suggests the same property resides in both DT and ACPI, but here we're
only using this for the ACPI case. DT has no want or need for this. I still feel
we should look at something more generic in the clock framework, although I do
agree with Mark that this should be properly specced.
> if (device_property_read_u32(dev, "dlg,micbias-lvl", &of_val32) >= 0)
> pdata->micbias_lvl = da7219_fw_micbias_lvl(dev, of_val32);
> else
> @@ -1905,7 +1907,10 @@ static int da7219_probe(struct snd_soc_component
> *component)
> da7219_handle_pdata(component);
>
> /* Check if MCLK provided */
> - da7219->mclk = devm_clk_get(component->dev, "mclk");
> + if (da7219->pdata->mclk_name)
> + da7219->mclk = clk_get(NULL, da7219->pdata->mclk_name);
> + if (!da7219->mclk)
> + da7219->mclk = devm_clk_get(component->dev, "mclk");
> if (IS_ERR(da7219->mclk)) {
> if (PTR_ERR(da7219->mclk) != -ENOENT) {
> ret = PTR_ERR(da7219->mclk);
> @@ -1971,6 +1976,9 @@ static void da7219_remove(struct snd_soc_component
> *component)
> clkdev_drop(da7219->dai_clks_lookup);
> #endif
>
> + if (da7219->pdata->mclk_name)
> + clk_put(da7219->mclk);
> +
> /* Supplies */
> regulator_bulk_disable(DA7219_NUM_SUPPLIES, da7219->supplies);
> }
> --
> 1.9.1
next prev parent reply other threads:[~2018-05-04 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 7:58 [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems Akshu Agrawal
2018-05-04 9:15 ` Adam Thomson [this message]
2018-05-07 4:50 ` Agrawal, Akshu
2018-05-07 6:39 ` Daniel Kurtz
2018-05-15 9:43 ` Agrawal, Akshu
2018-05-17 6:13 ` Mark Brown
2018-05-16 9:37 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E89032DDAA8B9408CB92943514A0337014C1EA102@SW-EX-MBX01.diasemi.com \
--to=adam.thomson.opensource@diasemi.com \
--cc=Alexander.Deucher@amd.com \
--cc=Support.Opensource@diasemi.com \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=djkurtz@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).