From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH] usb: typec: tcpm: Fix sink PDO starting index for PPS APDO selection
Date: Fri, 20 Jul 2018 14:16:33 +0000 [thread overview]
Message-ID: <2E89032DDAA8B9408CB92943514A0337019830B6AA@SW-EX-MBX01.diasemi.com> (raw)
In-Reply-To: <20180720135903.GB460@kroah.com>
On 20 July 2018 14:59, Greg Kroah-Hartman wrote:
> On Tue, Jul 17, 2018 at 03:36:19PM +0100, Adam Thomson wrote:
> > There is a bug in the sink PDO search code when trying to select
> > a PPS APDO. The current code actually sets the starting index for
> > searching to whatever value 'i' is, rather than choosing index 1
> > to avoid the first PDO (always 5V fixed). As a result, for sources
> > which support PPS but whose PPS APDO index does not match with the
> > supporting sink PPS APDO index for the platform, no valid PPS APDO
> > will be found so this feature will not be permitted.
> >
> > Sadly in testing, both Source and Sink capabilities matched up and
> > this was missed. Code is now updated to correctly set the start
> > index to 1, and testing with additional PPS capable sources show
> > this to work as expected.
> >
> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> > ---
> > drivers/usb/typec/tcpm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> > index 74e0cda..4f1f421 100644
> > --- a/drivers/usb/typec/tcpm.c
> > +++ b/drivers/usb/typec/tcpm.c
> > @@ -2238,7 +2238,7 @@ static unsigned int tcpm_pd_select_pps_apdo(struct
> tcpm_port *port)
> > * PPS APDO. Again skip the first sink PDO as this will
> > * always be 5V 3A.
> > */
> > - for (j = i; j < port->nr_snk_pdo; j++) {
> > + for (j = 1; j < port->nr_snk_pdo; j++) {
> > pdo = port->snk_pdo[j];
> >
> > switch (pdo_type(pdo)) {
>
> What commit id does this "fix"?
>
> Does it need to go into 4.18-final? To the stable kernels?
Sorry, missed that info. This fixes commit:
2eadc33f40d4c59dd0649f8b6958872d85ad05d7
'typec: tcpm: Add core support for sink side PPS'
This patch only went into v4.18-rc1 so should only be targeted for v4.18-final.
Do you want me to resend with this information added?
next prev parent reply other threads:[~2018-07-20 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 14:36 [PATCH] usb: typec: tcpm: Fix sink PDO starting index for PPS APDO selection Adam Thomson
2018-07-17 15:51 ` Guenter Roeck
2018-07-20 10:42 ` Heikki Krogerus
2018-07-20 13:59 ` Greg Kroah-Hartman
2018-07-20 14:16 ` Adam Thomson [this message]
2018-07-20 14:39 ` Greg Kroah-Hartman
2018-07-20 14:44 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E89032DDAA8B9408CB92943514A0337019830B6AA@SW-EX-MBX01.diasemi.com \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).