From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbbJEWYv (ORCPT ); Mon, 5 Oct 2015 18:24:51 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.168]:8931 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbbJEWYt (ORCPT ); Mon, 5 Oct 2015 18:24:49 -0400 X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-13.tower-39.messagelabs.com!1444083880!37498412!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Adam Thomson]" To: Mark Brown , "Opensource [Adam Thomson]" CC: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Support Opensource" Subject: RE: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver Thread-Topic: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver Thread-Index: AQHQ/4QkDtgZTwpX0U+v+4soFgbE0p5c/MiAgAB9X7A= Date: Mon, 5 Oct 2015 22:24:37 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A0337D46082F3@SW-EX-MBX01.diasemi.com> References: <8b10191f4e14b32f831d32c66c7edebd861b70ac.1444042230.git.Adam.Thomson.Opensource@diasemi.com> <20151005155543.GY12635@sirena.org.uk> In-Reply-To: <20151005155543.GY12635@sirena.org.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.50.162] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t95MOusU010766 On October 05, 2015 16:56, Mark Brown wrote: > On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote: > > > This patch adds support for DT bindings in the codec driver. > > As part of this support, the mclk data can now be provided and > > used to control the mclk during codec operation. > > Please split out the new MCLK configuration into a separate patch which > describes what that configuration is, it's much easier to review that > way. Otherwise there's a couple of minor issues here but nothing too > critical. Ok, no problem. Will do. > > > case SND_SOC_BIAS_STANDBY: > > if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) { > > + /* MCLK */ > > + clk_prepare_enable(da7213->mclk); > > + > > This doesn't check the return value. Yep, will update. > > > .driver = { > > .name = "da7213", > > + .of_match_table = da7213_of_match, > > Please use of_match_ptr() here. Ok, didn't know about that. Will update. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I