From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbcFUXSl (ORCPT ); Tue, 21 Jun 2016 19:18:41 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.151]:13428 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbcFUXSj convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2016 19:18:39 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGKsWRWlGSWpSXmKPExsUSt3Opse6mo5n hBpsmW1tcuXiIyaK3aTqTxdSHT9gs5h85x2ox881/Nouu1TtZLHY+fMtm8e1KB5PF8n39jBaX d81hs/i4dAOrxZTtR9gtHq94y26x8tMUFovWvUDu6jcLWBwEPDZ8bmLz2DnrLrvH4j0vmTw2r epk85h3MtDj8ya5ALYo1sy8pPyKBNaMe5PbmQreCVTcnVfbwNjN28XIxSEksJRR4vWpxexdjB wcbALuEr+P8nQxcnKICFRI7JjXxgRSwyywhVXi2IlOFpCEsECoxLFDe9khisIkvt14yghhW0k 0HJ/HBGKzCKhKPP/Yygxi8wr4SVzbfp4VxBYCGvrh5FKwGk4BW4kP3Y1gNqOArMSXxtVg9cwC 4hK3nswHi0sICEgs2XOeGcIWlXj5+B8rhC0vsXv7OSjbXuL1vXcsIPdLCOhL9DUWQ4QNJVZNO 8ACYZtLrO7dDzVeR2LB7k9sELa2xLKFr6HOFJQ4OfMJywRG8VlIrpiFpGUWkpZZSFoWMLKsYt QoTi0qSy3SNTLSSyrKTM8oyU3MzNE1NDDVy00tLk5MT81JTCrWS87P3cQITA/1DAyMOxj3tPs dYpTkYFIS5ZVcnxkuxJeUn1KZkVicEV9UmpNafIhRhoNDSYL3zUGgnGBRanpqRVpmDjBRwaQl OHiURHjtDgGleYsLEnOLM9MhUqcYFaXEeUVAEgIgiYzSPLg2WHK8xCgrJczLyMDAIMRTkFqUm 1mCKv+KUZyDUUmY1wtkCk9mXgnc9FdAi5mAFi/rTwdZXJKIkJJqYKzY9brG6NpKszOPFjD9Ob Fi7Tu/jWtSHjyLe5VgMsF2+R2NkDOi89mb//DzXth52e7M5exdWx9P0pYWtYw1n+JjvaB3k/U SAZbTHr11bdcM6yO+sW33njNxctDb7+Grn63KMPe0232w3XT1/I5zk9xeP0z8KNwcsuij4r2p xk3ME7LY1cVUm9uUWIozEg21mIuKEwGzZF9wiQMAAA== X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-7.tower-180.messagelabs.com!1466549682!41588278!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Adam Thomson]" To: "Rafael J. Wysocki" , "Opensource [Adam Thomson]" CC: Robert Moore , Lv Zheng , Heikki Krogerus , Mika Westerberg , Len Brown , "Andy Shevchenko" , Rob Herring , Frank Rowand , Mark Brown , Liam Girdwood , linux-acpi , devicetree , alsa-devel , linux-kernel , Support Opensource , Sathyanarayana Nujella Subject: RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions Thread-Topic: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions Thread-Index: AQHRy+VhJIXwxWn9ak2bmTxsmbn/LJ/0cF0AgAAXBIA= Date: Tue, 21 Jun 2016 22:54:39 +0000 Message-ID: <2E89032DDAA8B9408CB92943514A0337D4644644@SW-EX-MBX01.diasemi.com> References: <6274a042-da99-e3e6-20f2-37ce2651645c@intel.com> In-Reply-To: <6274a042-da99-e3e6-20f2-37ce2651645c@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.50.131] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 21/06/2016 20:34:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 June 2016 23:30, Rafael J. Wysocki wrote: > > This patch set converts the da7219 codec driver to use device/fwnode functions > > to access properties, instead of the DT only of_* functions, allowing ACPI > > to be used as well. > > > > The DT bindings for da7219 have a device node for the main codec properties, > > and a named child node (da7219_aad), which contains all of the accessory > > detection related properties for the device. ACPI also supports this kind of > > FW hierarchy (data only sub-nodes), but some support in the kernel needs to be > > added to take make use of this in driver code. > > > > The first patch adds functions to allow searching for a named child node of a > > device, for both DT and ACPI, and the second patch updates the codec driver to > > use the standard device/fwnode calls, including this new function. > > > > These changes are based on the v4.7-rc4 kernel. > > > > Changes in v4: > > - Rebase to v4.7-rc4 > > - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes. > > > > Changes in v3: > > - Use of_node_cmp() in device_get_named_child_node() to match DT node. > > > > Changes in v2: > > - Rebase to v4.7-rc1 > > - Small updates to codec patch based on previous reviewer comments > > > > Adam Thomson (2): > > device property: Add function to search for named child of device > > ASoC: da7219: Convert driver to use generic device/fwnode functions > > > > drivers/base/property.c | 28 ++++++++++++ > > include/acpi/acpi_bus.h | 7 +++ > > include/linux/acpi.h | 6 +++ > > include/linux/of.h | 14 +++--- > > include/linux/property.h | 3 ++ > > sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++-------------------- > - > > sound/soc/codecs/da7219.c | 34 +++++++------- > > 7 files changed, 119 insertions(+), 76 deletions(-) > > > > -- > > 1.9.3 > > > I'm fine with the first patch and the second one carries a couple of > ACKs already, so do you want me to apply them both? Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes though before we can proceed.