From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdFZFlI convert rfc822-to-8bit (ORCPT ); Mon, 26 Jun 2017 01:41:08 -0400 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdFZFlB (ORCPT ); Mon, 26 Jun 2017 01:41:01 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt From: David Gstir In-Reply-To: <20170620012858.GA16207@gondor.apana.org.au> Date: Mon, 26 Jun 2017 07:40:58 +0200 Cc: =?utf-8?Q?Horia_Geant=C4=83?= , Dan Douglass , "davem@davemloft.net" , "richard@sigma-star.at" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <2EF4805B-514F-48AD-95BB-170AF7B24D36@sigma-star.at> References: <20170602122446.2427-1-david@sigma-star.at> <20170602122446.2427-2-david@sigma-star.at> <20170620012858.GA16207@gondor.apana.org.au> To: Herbert Xu X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Herbert, > On 20 Jun 2017, at 03:28, Herbert Xu wrote: > > On Mon, Jun 19, 2017 at 10:31:27AM +0000, Horia Geantă wrote: >> >> IIUC, IV update is required only in case of CBC. >> Since this callback is used also for CTR, we should avoid the copy: >> if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ... > > No it is needed for CTR too. So, am I correct in assuming that it is required for all modes including AEAD modes like GCM? In that case I'll include a fix for the CAAM GCM mode too. Thanks, David