linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH] gpiolib: Take MUX usage into account
Date: Tue, 06 Aug 2019 22:54:48 +0300	[thread overview]
Message-ID: <2F7B6E95-045E-4F57-B2CB-858BEE298986@gmail.com> (raw)
In-Reply-To: <CACRpkdaTmxQn2Z=vD6nyqk-iXCFrnCG1xpkXwO3-+sazOhGBvw@mail.gmail.com>



On August 6, 2019 4:11:27 PM GMT+03:00, Linus Walleij <linus.walleij@linaro.org> wrote:
>On Tue, Aug 6, 2019 at 3:04 PM Linus Walleij <linus.walleij@linaro.org>
>wrote:
>> On Sat, Aug 3, 2019 at 3:34 PM Ramon Fried <rfried.dev@gmail.com>
>wrote:
>>
>> > From: Stefan Wahren <stefan.wahren@i2se.com>
>> >
>> > The user space like gpioinfo only see the GPIO usage but not the
>> > MUX usage (e.g. I2C or SPI usage) of a pin. As a user we want to
>know which
>> > pin is free/safe to use. So take the MUX usage of strict pinmux
>controllers
>> > into account to get a more realistic view for ioctl
>GPIO_GET_LINEINFO_IOCTL.
>> >
>> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> > Tested-By: Ramon Fried <rfried.dev@gmail.com>
>> > Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
>> > ---
>> > Sending Stefan's RFC as patch, as I tested it and it seems to work,
>> > additionally, an accompanying fix was made by me to gpiolibd to fix
>a
>> > display error of the actual result:
>> > https://patchwork.ozlabs.org/patch/1139923/
>>
>> This is mostly fine, some style nits so I fixed it up when
>> applying.
>
>Ooops no. It needs a deeper rework in accordance to my comments
>last time it was posted. Please read this reply to Stefan's patch
>and address the comments:
>
NP, I'll try to address these in a new patch. 
Thanks. 
Ramon 
>https://lore.kernel.org/linux-gpio/CACRpkdb5DjAMRYkT+b0U6HVk7E6ccLT79-LB=QGQWWtE17aPUg@mail.gmail.com/
>
>Yours,
>Linus Walleij

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

      reply	other threads:[~2019-08-06 19:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-03 13:34 [PATCH] gpiolib: Take MUX usage into account Ramon Fried
2019-08-05  8:33 ` Bartosz Golaszewski
2019-08-06 13:04 ` Linus Walleij
2019-08-06 13:11   ` Linus Walleij
2019-08-06 19:54     ` Ramon Fried [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2F7B6E95-045E-4F57-B2CB-858BEE298986@gmail.com \
    --to=rfried.dev@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).