* [PATCH] RDS: IB: Remove deprecated create_workqueue
@ 2016-06-07 19:33 Bhaktipriya Shridhar
2016-06-07 20:31 ` Santosh Shilimkar
2016-06-11 5:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Bhaktipriya Shridhar @ 2016-06-07 19:33 UTC (permalink / raw)
To: Santosh Shilimkar, David S. Miller
Cc: Tejun Heo, netdev, linux-rdma, rds-devel, linux-kernel
alloc_workqueue replaces deprecated create_workqueue().
Since the driver is infiniband which can be used as block device and the
workqueue seems involved in regular operation of the device, so a
dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee
forward progress under memory pressure.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
net/rds/ib_rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
index f7164ac..a0f21b6 100644
--- a/net/rds/ib_rdma.c
+++ b/net/rds/ib_rdma.c
@@ -618,7 +618,7 @@ struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_ibdev,
int rds_ib_mr_init(void)
{
- rds_ib_mr_wq = create_workqueue("rds_mr_flushd");
+ rds_ib_mr_wq = alloc_workqueue("rds_mr_flushd", WQ_MEM_RECLAIM, 0);
if (!rds_ib_mr_wq)
return -ENOMEM;
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDS: IB: Remove deprecated create_workqueue
2016-06-07 19:33 [PATCH] RDS: IB: Remove deprecated create_workqueue Bhaktipriya Shridhar
@ 2016-06-07 20:31 ` Santosh Shilimkar
2016-06-11 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2016-06-07 20:31 UTC (permalink / raw)
To: Bhaktipriya Shridhar, David S. Miller
Cc: Tejun Heo, netdev, linux-rdma, rds-devel, linux-kernel
Hi,
On 6/7/2016 12:33 PM, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> Since the driver is infiniband which can be used as block device and the
> workqueue seems involved in regular operation of the device, so a
> dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee
> forward progress under memory pressure.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
Looks fine.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDS: IB: Remove deprecated create_workqueue
2016-06-07 19:33 [PATCH] RDS: IB: Remove deprecated create_workqueue Bhaktipriya Shridhar
2016-06-07 20:31 ` Santosh Shilimkar
@ 2016-06-11 5:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-11 5:52 UTC (permalink / raw)
To: bhaktipriya96
Cc: santosh.shilimkar, tj, netdev, linux-rdma, rds-devel, linux-kernel
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Wed, 8 Jun 2016 01:03:45 +0530
> alloc_workqueue replaces deprecated create_workqueue().
>
> Since the driver is infiniband which can be used as block device and the
> workqueue seems involved in regular operation of the device, so a
> dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee
> forward progress under memory pressure.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-11 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 19:33 [PATCH] RDS: IB: Remove deprecated create_workqueue Bhaktipriya Shridhar
2016-06-07 20:31 ` Santosh Shilimkar
2016-06-11 5:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).