From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108AbcFGUbx (ORCPT ); Tue, 7 Jun 2016 16:31:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28257 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755897AbcFGUbv (ORCPT ); Tue, 7 Jun 2016 16:31:51 -0400 Subject: Re: [PATCH] RDS: IB: Remove deprecated create_workqueue To: Bhaktipriya Shridhar , "David S. Miller" References: <20160607193345.GA10562@Karyakshetra> Cc: Tejun Heo , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <2a32db91-441d-7536-0c45-dc26c486d9fe@oracle.com> Date: Tue, 7 Jun 2016 13:31:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160607193345.GA10562@Karyakshetra> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 6/7/2016 12:33 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > Since the driver is infiniband which can be used as block device and the > workqueue seems involved in regular operation of the device, so a > dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee > forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar > --- Looks fine. Acked-by: Santosh Shilimkar