From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Alexander A. Filippov" <a.filippov@yadro.com>
Cc: linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Joel Stanley" <joel@jms.id.au>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC
Date: Thu, 16 Apr 2020 13:26:50 +0930 [thread overview]
Message-ID: <2a546e5b-5a5e-42e8-a201-67cd9063249f@www.fastmail.com> (raw)
In-Reply-To: <20200410145904.GA15615@bbwork.lan>
On Sat, 11 Apr 2020, at 00:29, Alexander A. Filippov wrote:
> On Fri, Apr 10, 2020 at 02:29:47PM +0930, Andrew Jeffery wrote:
> >
> >
> > > +&i2c11 {
> > > + status = "okay";
> > > +};
> > > +
> > > +&i2c12 {
> > > + status = "okay";
> > > +};
> >
> > Are you accessing devices on the busses from userspace? It would
> > be helpful to comment here why you're enabling all of these busses
> > but not describing any devices on them, if it's necessary to enable
> > them at all.
> >
>
> Yes, some of them are unused and may be removed.
> For others I'll add comments in the next version.
>
> > > +
> > > +&adc {
> > > + status = "okay";
> >
> > You should specify the pinmux configuration for the channels you're using
> > to ensure exclusive access to those pins (otherwise they could be exported
> > e.g. as GPIOs).
>
> It was just copied from Romulus and looks like I missed iio-hwmon-battery.
> Is it what you meant?
The Romulus devicetree may need to be fixed too :)
Andrew
next prev parent reply other threads:[~2020-04-16 3:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 10:15 [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC Alexander Filippov
2020-04-10 4:59 ` Andrew Jeffery
2020-04-10 14:59 ` Alexander A. Filippov
2020-04-16 3:56 ` Andrew Jeffery [this message]
2020-04-23 11:21 Alexander Filippov
2020-04-23 12:05 ` Alexander A. Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a546e5b-5a5e-42e8-a201-67cd9063249f@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=a.filippov@yadro.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).