From: George Kennedy <george.kennedy@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jslaby@suse.com, ebiggers@google.com,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
dhaval.giani@oracle.com
Subject: Re: [PATCH 1/1] vt_ioctl: prevent VT_RESIZEX font height change from causing potential out-of-bounds access
Date: Wed, 29 Jul 2020 14:50:22 -0400 [thread overview]
Message-ID: <2a64913e-517e-5f2d-f96e-6bc10104adbe@oracle.com> (raw)
In-Reply-To: <20200729125311.GA2912372@kroah.com>
Hi Greg,
I will re-work this patch based on comments from Dan.
Thank you,
George
On 7/29/2020 8:53 AM, Greg KH wrote:
> On Wed, Jul 29, 2020 at 08:39:41AM -0400, George Kennedy wrote:
>> Add a VT_RESIZEX check to ensure that changing the font height will not
>> cause a potential out-of-bounds access. The candidate font height contained
>> in "v_clin", though below the max, could still result in accesses beyond
>> the allocated font data size.
>>
>> Signed-off-by: George Kennedy <george.kennedy@oracle.com>
>> Reported-by: syzbot+38a3699c7eaf165b97a6@syzkaller.appspotmail.com
> Did syzbot also test this that it fixes the reported issue?
>
> What commit does this fix? Should it go back farther to stable releases
> too?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-07-29 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 12:39 [PATCH 1/1] vt_ioctl: prevent VT_RESIZEX font height change from causing potential out-of-bounds access George Kennedy
2020-07-29 12:53 ` Greg KH
2020-07-29 18:50 ` George Kennedy [this message]
2020-07-29 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a64913e-517e-5f2d-f96e-6bc10104adbe@oracle.com \
--to=george.kennedy@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).