From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751757AbdFHMbw (ORCPT ); Thu, 8 Jun 2017 08:31:52 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52855 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbdFHMbu (ORCPT ); Thu, 8 Jun 2017 08:31:50 -0400 Subject: Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20170608081242.27061-1-gregkh@linuxfoundation.org> <20170608081242.27061-3-gregkh@linuxfoundation.org> Cc: Michael Cyr , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org From: "Bryant G. Ly" Date: Thu, 8 Jun 2017 07:31:43 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170608081242.27061-3-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17060812-0044-0000-0000-00000349A720 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007194; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00871894; UDB=6.00433700; IPR=6.00651882; BA=6.00005406; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015744; XFM=3.00000015; UTC=2017-06-08 12:31:46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060812-0045-0000-0000-00000777A8EC Message-Id: <2a7a2937-9f0e-de01-1690-21cf92bb45f2@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706080224 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The class_attrs pointer is going away and it's not even being used in > this driver, so just remove it entirely. > > Cc: "Bryant G. Ly" > Cc: Michael Cyr > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index d390325c99ec..b480878e3258 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > @@ -3915,10 +3915,6 @@ static const struct target_core_fabric_ops ibmvscsis_ops = { > > static void ibmvscsis_dev_release(struct device *dev) {}; > > -static struct class_attribute ibmvscsis_class_attrs[] = { > - __ATTR_NULL, > -}; > - > static struct device_attribute dev_attr_system_id = > __ATTR(system_id, S_IRUGO, system_id_show, NULL); > > @@ -3938,7 +3934,6 @@ ATTRIBUTE_GROUPS(ibmvscsis_dev); > static struct class ibmvscsis_class = { > .name = "ibmvscsis", > .dev_release = ibmvscsis_dev_release, > - .class_attrs = ibmvscsis_class_attrs, > .dev_groups = ibmvscsis_dev_groups, > }; > Thanks Greg, ACK. -Bryant