From: Jon Hunter <jonathanh@nvidia.com>
To: Akhil R <akhilrajeev@nvidia.com>, <andy.shevchenko@gmail.com>
Cc: <bgolaszewski@baylibre.com>, <kyarlagadda@nvidia.com>,
<ldewangan@nvidia.com>, <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <mperttunen@nvidia.com>,
<smangipudi@nvidia.com>, <thierry.reding@gmail.com>
Subject: Re: [PATCH v4] gpio: tegra186: Add ACPI support
Date: Thu, 1 Jul 2021 06:53:38 +0100 [thread overview]
Message-ID: <2a8eb285-3b71-199c-1bf4-39fb47fac77e@nvidia.com> (raw)
In-Reply-To: <1625115672-17932-1-git-send-email-akhilrajeev@nvidia.com>
On 01/07/2021 06:01, Akhil R wrote:
> Add ACPI module ID to probe the driver from the ACPI based bootloader
> firmware.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/gpio/gpio-tegra186.c | 32 +++++++++++++++++++++++++-------
> 1 file changed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index 1bd9e44..e0ba8cd 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -620,15 +620,21 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
> if (!gpio)
> return -ENOMEM;
>
> - gpio->soc = of_device_get_match_data(&pdev->dev);
> + gpio->soc = device_get_match_data(&pdev->dev);
>
> gpio->secure = devm_platform_ioremap_resource_byname(pdev, "security");
> - if (IS_ERR(gpio->secure))
> - return PTR_ERR(gpio->secure);
> -
> gpio->base = devm_platform_ioremap_resource_byname(pdev, "gpio");
> - if (IS_ERR(gpio->base))
> - return PTR_ERR(gpio->base);
> +
> + if (IS_ERR(gpio->secure) || IS_ERR(gpio->base)) {
The OR here seems a bit odd, my preference would be how Andy suggested
initially ...
gpio->secure = devm_platform_ioremap_resource_byname(pdev, "security");
if (IS_ERR(gpio->secure)) {
gpio->secure = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(gpio->secure))
return PTR_ERR(gpio->secure)
}
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2021-07-01 5:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 10:05 [PATCH] gpio: tegra186: Add ACPI support Akhil R
2021-06-17 14:54 ` Linus Walleij
2021-06-17 15:21 ` Andy Shevchenko
2021-06-18 13:39 ` [PATCH v2] " Akhil R
2021-06-18 14:31 ` Andy Shevchenko
2021-06-21 15:08 ` Akhil R
2021-06-29 15:17 ` Akhil R
2021-06-30 16:14 ` Andy Shevchenko
2021-06-30 17:47 ` Akhil R
2021-06-30 18:17 ` [PATCH v3] " Akhil R
2021-06-30 18:23 ` Andy Shevchenko
2021-07-01 5:01 ` [PATCH v4] " Akhil R
2021-07-01 5:53 ` Jon Hunter [this message]
2021-07-01 9:00 ` [PATCH v5] " Akhil R
2021-07-08 13:08 ` Jon Hunter
2021-07-16 8:31 ` Bartosz Golaszewski
2021-07-19 4:46 ` [PATCH v6] " Akhil R
2021-08-05 19:30 ` Bartosz Golaszewski
2021-06-18 19:39 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8eb285-3b71-199c-1bf4-39fb47fac77e@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).