From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D66BC5ACBF for ; Wed, 11 Mar 2020 18:18:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 120902072F for ; Wed, 11 Mar 2020 18:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730796AbgCKSSy (ORCPT ); Wed, 11 Mar 2020 14:18:54 -0400 Received: from mga12.intel.com ([192.55.52.136]:56037 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730677AbgCKSSx (ORCPT ); Wed, 11 Mar 2020 14:18:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 11:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,541,1574150400"; d="scan'208";a="353937802" Received: from sai-dev-mach.sc.intel.com ([143.183.140.153]) by fmsmga001.fm.intel.com with ESMTP; 11 Mar 2020 11:18:53 -0700 Message-ID: <2a950833c6f2e31c987cee5101fc13eddb36a468.camel@intel.com> Subject: Re: [PATCH V1 09/13] selftests/resctrl: Modularize fill_buf for new CAT test case From: Sai Praneeth Prakhya To: Reinette Chatre , shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, tony.luck@intel.com, babu.moger@amd.com, james.morse@arm.com, ravi.v.shankar@intel.com, fenghua.yu@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 Mar 2020 11:14:06 -0700 In-Reply-To: <2b7e2ef2-8e80-1e5e-41ac-4fc4726425ac@intel.com> References: <43b368952bb006ee973311d9c9ae0eb53d8e7f60.1583657204.git.sai.praneeth.prakhya@intel.com> <4c84be1d-8839-2c85-b294-7e3c454240bb@intel.com> <7a1f93d4516a7de99c5dbc4afd6279d6fe7aa126.camel@intel.com> <50cb755f-e112-5d71-11fa-a7cbc951d91e@intel.com> <588d18133c0ad76b375a920b6e6cc1598564163a.camel@intel.com> <2b7e2ef2-8e80-1e5e-41ac-4fc4726425ac@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Reinette, On Wed, 2020-03-11 at 11:10 -0700, Reinette Chatre wrote: > Hi Sai, > > On 3/11/2020 10:45 AM, Sai Praneeth Prakhya wrote: > > On Wed, 2020-03-11 at 08:44 -0700, Reinette Chatre wrote: > > > On 3/10/2020 6:04 PM, Sai Praneeth Prakhya wrote: > > > > On Tue, 2020-03-10 at 14:59 -0700, Reinette Chatre wrote: > > > > > On 3/6/2020 7:40 PM, Sai Praneeth Prakhya wrote: > > > > > > Currently fill_buf (in-built benchmark) runs as a separate process > > > > > > a > > > > > > > > [SNIP] > > > Maintaining the end pointer is unusual. The start of the buffer and the > > > size are known properties that the end of the buffer can be computed > > > from. Not a problem, it just seems inconsistent that some of the buffer > > > functions operate on the start pointer and size while others operate on > > > the start pointer and end pointer. > > > > Ok.. makes sense. I will try to make it consistent by using endptr all the > > time. One advantage of using endptr is that we could just compute endptr > > once > > and use it when needed by passing it as variable (will try to not make it > > global variable). > > This may add unnecessary complexity because from what I can tell some of > those calls require buffer size and this would then require needing to > recompute the buffer size based on the start and end pointers. Do you > really need the end pointer? Can you not just use the start pointer and > buffer size? Ok.. makes sense. Will use buffer size. Regards, Sai