From: Jens Axboe <axboe@kernel.dk>
To: Lin Feng <linf@wangsu.com>, paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request
Date: Fri, 16 Apr 2021 06:09:40 -0600 [thread overview]
Message-ID: <2ac2fd8d-08df-9412-c551-35f34bf7333b@kernel.dk> (raw)
In-Reply-To: <20210415034326.214227-1-linf@wangsu.com>
On 4/14/21 9:43 PM, Lin Feng wrote:
> Since commit 01e99aeca39796003 'blk-mq: insert passthrough request into
> hctx->dispatch directly', passthrough request should not appear in
> IO-scheduler any more, so blk_rq_is_passthrough checking in addon IO
> schedulers is redundant.
>
> (Notes: this patch passes generic IO load test with hdds under SAS
> controller and hdds under AHCI controller but obviously not covers all.
> Not sure if passthrough request can still escape into IO scheduler from
> blk_mq_sched_insert_requests, which is used by blk_mq_flush_plug_list and
> has lots of indirect callers.)
Applied, with the bfq bits hand edited to apply for 5.13.
--
Jens Axboe
prev parent reply other threads:[~2021-04-16 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:43 [RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request Lin Feng
2021-04-16 2:14 ` Ming Lei
2021-04-16 12:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac2fd8d-08df-9412-c551-35f34bf7333b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linf@wangsu.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).