From: Joe Perches <joe@perches.com>
To: Arnold Chand <arnold.chand@gmail.com>,
"eric@anholt.net" <eric@anholt.net>
Cc: "stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks
Date: Mon, 12 Nov 2018 17:06:59 -0800 [thread overview]
Message-ID: <2ac68de6b842751f771c43e0a4d8777475ace323.camel@perches.com> (raw)
In-Reply-To: <46bb5564b6bd6cad78c01b4d8026c7c72a870b15.camel@gmail.com>
On Mon, 2018-11-12 at 19:45 -0500, Arnold Chand wrote:
> Corrected warnings and checks provided by scripts/checkpatch.pl which
> includes: alignment of parenthesis, lines over 80 characters and mutex
> definition without comment.
[]
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
[]
> @@ -162,7 +163,8 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
> mutex_lock(&chip->audio_mutex);
>
> for (i = 0; i < 4; i++)
> - val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8);
> + val |= (unsigned int)ucontrol->value.iec958.status[i] <<
> + (i * 8);
Perhaps this should be
val = get_unaligned_be32(ucontrol->value.iec958.status);
next prev parent reply other threads:[~2018-11-13 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 0:45 [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks Arnold Chand
2018-11-13 1:06 ` Joe Perches [this message]
2018-11-13 1:09 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac68de6b842751f771c43e0a4d8777475ace323.camel@perches.com \
--to=joe@perches.com \
--cc=arnold.chand@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).