From: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Harald Freudenberger <FREUDE@de.ibm.com>
Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>,
alex.williamson@redhat.com, alifm@linux.vnet.ibm.com,
berrange@redhat.com, bjsdjshi@linux.vnet.ibm.com,
borntrae@linux.ibm.com, fiuczy@linux.vnet.ibm.com,
heicars2@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com,
kvm@vger.kernel.org, kwankhede@nvidia.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
mjrosato@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com,
pasic@linux.vnet.ibm.com, pbonzini@redhat.com,
Reinhard Buendgen <BUENDGEN@de.ibm.com>,
thuth@redhat.com
Subject: Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization
Date: Tue, 17 Apr 2018 10:26:57 -0400 [thread overview]
Message-ID: <2ac8b862-e2dc-843e-a0b8-906fa32b42f4@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180417121044.5c8f2182.cohuck@redhat.com>
On 04/17/2018 06:10 AM, Cornelia Huck wrote:
> On Tue, 17 Apr 2018 09:49:58 +0200
> "Harald Freudenberger" <FREUDE@de.ibm.com> wrote:
>
>> Didn't we say that when APXA is not available there is no Crypto support
>> for KVM ?
> [Going by the code, as I don't have access to the architecture]
>
> Current status seems to be:
> - setup crycb if facility 76 is available (that's MSAX3, I guess?)
The crycb is set up regardless of whether STFLE.76 (MSAX3) is
installed or not.
> - use format 2 if APXA is available, else use format 1
Use format 0 if MSAX3 is not available
Use format 1 if MSAX3 is available but APXA is not
Use format 2 if MSAX3 and APXA is available
>
> From Tony's patch description, the goal seems to be:
> - setup crycb even if MSAX3 is not available
Yes, that is true
>
> So my understanding is that we use APXA only to decide on the format of
> the crycb, but provide it in any case?
Yes, that is true
>
> (Not providing a crycb if APXA is not available would be loss of
> functionality, I guess? Deciding not to provide vfio-ap if APXA is not
> available is a different game, of course.)
This would require a change to enabling the CPU model feature for
AP.
>
next prev parent reply other threads:[~2018-04-17 14:27 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 21:22 [PATCH v4 00/15] s390: vfio-ap: guest dedicated crypto adapters Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 01/15] s390: zcrypt: externalize AP instructions available function Tony Krowiak
2018-04-16 8:44 ` Pierre Morel
2018-04-16 12:11 ` Cornelia Huck
2018-04-17 13:31 ` Tony Krowiak
2018-04-17 16:56 ` Cornelia Huck
2018-04-17 18:14 ` Tony Krowiak
[not found] ` <db4245ec-0191-2c32-5c1c-12af50b944c6@linux.vnet.ibm.com>
2018-04-23 7:04 ` Cornelia Huck
2018-04-16 15:59 ` Pierre Morel
[not found] ` <OFF71B62BB.95581C62-ON00258272.00264957-C1258272.0026A1CA@notes.na.collabserv.com>
2018-04-17 12:44 ` Pierre Morel
2018-05-04 7:19 ` David Hildenbrand
2018-05-07 14:02 ` Tony Krowiak
2018-05-07 14:55 ` David Hildenbrand
2018-04-15 21:22 ` [PATCH v4 02/15] KVM: s390: reset crypto attributes for all vcpus Tony Krowiak
2018-04-17 11:34 ` Cornelia Huck
2018-04-17 13:47 ` Tony Krowiak
2018-04-17 14:09 ` Cornelia Huck
2018-04-17 14:29 ` Halil Pasic
2018-04-17 14:55 ` Tony Krowiak
2018-04-17 15:10 ` Cornelia Huck
2018-04-17 17:54 ` Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 03/15] KVM: s390: refactor crypto initialization Tony Krowiak
2018-04-16 8:56 ` Pierre Morel
[not found] ` <OFE3FE11B1.8E1BDDEF-ON00258272.002AEDB1-C1258272.002B06EF@notes.na.collabserv.com>
2018-04-17 10:10 ` Cornelia Huck
2018-04-17 14:26 ` Tony Krowiak [this message]
2018-04-17 15:21 ` Cornelia Huck
2018-04-17 18:08 ` Tony Krowiak
2018-04-18 7:49 ` Cornelia Huck
2018-04-22 14:52 ` Tony Krowiak
2018-04-23 7:03 ` Cornelia Huck
2018-04-24 13:01 ` Tony Krowiak
2018-04-24 13:13 ` Cornelia Huck
2018-04-17 14:15 ` Tony Krowiak
2018-04-17 15:52 ` Pierre Morel
2018-04-22 21:11 ` Tony Krowiak
2018-04-17 14:30 ` Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 04/15] KVM: s390: CPU model support for AP virtualization Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 05/15] KVM: s390: enable/disable AP interpretive execution Tony Krowiak
2018-04-16 10:51 ` Pierre Morel
2018-04-16 11:13 ` Pierre Morel
2018-04-16 11:52 ` Halil Pasic
2018-04-17 15:12 ` Tony Krowiak
2018-04-17 15:09 ` Tony Krowiak
2018-04-17 15:02 ` Tony Krowiak
2018-04-17 16:13 ` Pierre Morel
2018-04-17 16:22 ` Tony Krowiak
2018-04-17 16:55 ` Pierre Morel
2018-04-17 18:11 ` Tony Krowiak
2018-04-18 8:31 ` Pierre Morel
2018-04-19 14:28 ` Tony Krowiak
2018-04-17 16:34 ` Tony Krowiak
2018-04-16 11:12 ` Halil Pasic
2018-04-17 15:11 ` Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 06/15] s390: vfio-ap: base implementation of VFIO AP device driver Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 07/15] s390: vfio-ap: register matrix device with VFIO mdev framework Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 08/15] KVM: s390: interfaces to (de)configure guest's AP matrix Tony Krowiak
2018-04-16 5:04 ` kbuild test robot
2018-04-23 13:46 ` Pierre Morel
2018-04-25 16:21 ` Tony Krowiak
2018-05-02 14:57 ` Pierre Morel
2018-05-03 14:41 ` Tony Krowiak
2018-05-03 16:01 ` Pierre Morel
2018-05-07 14:14 ` Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 09/15] s390: vfio-ap: sysfs interfaces to configure adapters Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 10/15] s390: vfio-ap: sysfs interfaces to configure domains Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 11/15] s390: vfio-ap: sysfs interfaces to configure control domains Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 12/15] s390: vfio-ap: sysfs interface to view matrix mdev matrix Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 13/15] KVM: s390: configure the guest's AP devices Tony Krowiak
2018-04-16 13:05 ` Pierre Morel
2018-04-16 14:51 ` Halil Pasic
2018-04-17 16:12 ` Tony Krowiak
2018-04-17 16:08 ` Tony Krowiak
2018-04-17 16:18 ` Pierre Morel
2018-04-17 16:36 ` Tony Krowiak
2018-04-18 11:56 ` Pierre Morel
2018-04-22 14:54 ` Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 14/15] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl Tony Krowiak
2018-04-15 21:22 ` [PATCH v4 15/15] s390: doc: detailed specifications for AP virtualization Tony Krowiak
2018-04-16 13:13 ` Pierre Morel
2018-04-16 13:53 ` Cornelia Huck
2018-04-17 16:16 ` Tony Krowiak
2018-04-17 16:14 ` Tony Krowiak
2018-04-17 16:25 ` Pierre Morel
2018-04-17 16:37 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac8b862-e2dc-843e-a0b8-906fa32b42f4@linux.vnet.ibm.com \
--to=akrowiak@linux.vnet.ibm.com \
--cc=BUENDGEN@de.ibm.com \
--cc=FREUDE@de.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntrae@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=fiuczy@linux.vnet.ibm.com \
--cc=heicars2@linux.vnet.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=mschwid2@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).