From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
broonie@kernel.org, andi@etezian.org
Cc: kernel@axis.com, alim.akhtar@samsung.com,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA
Date: Mon, 19 Sep 2022 11:43:16 +0200 [thread overview]
Message-ID: <2ace1136-25e0-ef6b-8960-29fbc7050e22@linaro.org> (raw)
In-Reply-To: <20220916113951.228398-5-vincent.whitchurch@axis.com>
On 16/09/2022 13:39, Vincent Whitchurch wrote:
> The COUNT_VALUE in the PACKET_CNT register is 16-bit so the maximum
> value is 65535. Asking the driver to transfer a larger size currently
> leads to the DMA transfer timing out. Fix this by splitting the
> transfer as needed.
>
> With this, the len>64 KiB tests in spi-loopback-test pass.
>
> (Note that len==64 KiB tests work even without this patch for some reason.
> The driver programs 0 to the COUNT_VALUE field in that case, but it's
> unclear if it's by design, since the hardware documentation doesn't say
> anything about the behaviour when COUNT_VALUE == 0, so play it safe and
> split at 65535.)
>
> Fixes: 230d42d422e7b69 ("spi: Add s3c64xx SPI Controller driver")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-19 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:39 [PATCH 0/4] spi: Fix DMA bugs in (not only) spi-s3c64xx Vincent Whitchurch
2022-09-16 11:39 ` [PATCH 1/4] spi: spi-loopback-test: Add test to trigger DMA/PIO mixing Vincent Whitchurch
2022-09-19 14:41 ` Mark Brown
2022-09-16 11:39 ` [PATCH 2/4] spi: Save current RX and TX DMA devices Vincent Whitchurch
2022-09-16 11:39 ` [PATCH 3/4] spi: Fix cache corruption due to DMA/PIO overlap Vincent Whitchurch
2022-09-16 16:06 ` kernel test robot
2022-09-16 11:39 ` [PATCH 4/4] spi: s3c64xx: Fix large transfers with DMA Vincent Whitchurch
2022-09-19 9:43 ` Krzysztof Kozlowski [this message]
2022-09-19 14:38 ` Mark Brown
2022-09-26 13:42 ` Vincent Whitchurch
2022-09-26 13:52 ` Mark Brown
2022-09-19 16:50 ` (subset) [PATCH 0/4] spi: Fix DMA bugs in (not only) spi-s3c64xx Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ace1136-25e0-ef6b-8960-29fbc7050e22@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).