From: Liang Yang <liang.yang@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <jianxin.pan@amlogic.com>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<linux-mtd@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH nand-next 0/2] meson-nand: support for older SoCs
Date: Thu, 21 Mar 2019 20:10:25 +0800 [thread overview]
Message-ID: <2aebeb86-1cf6-26e9-b19b-03c2a55bff9c@amlogic.com> (raw)
In-Reply-To: <CAFBinCBfkr-yyR4Vbd1HVmXVCOKuK-Kw1HKz4SMt9G3eA49HQQ@mail.gmail.com>
Hi Martin,
On 2019/3/21 4:48, Martin Blumenstingl wrote:
> Hi Liang,
>
> On Wed, Mar 20, 2019 at 4:32 AM Liang Yang <liang.yang@amlogic.com> wrote:
>>
>> Hi Martin,
>>
>> Thanks for your time.
>> On 2019/3/20 4:27, Martin Blumenstingl wrote:
>>> Hello Liang,
>>>
>>> On Sat, Mar 16, 2019 at 11:55 AM Martin Blumenstingl
>>> <martin.blumenstingl@googlemail.com> wrote:
>>> [...]
>
>> Allocating a fixed size info buffer before nand_scan_ident and attach it
>> on the struct meson_nfc; Or considering not use dma for reading data
>> less than 8 bytes. Both can reduce kmalloc and kfree calling. Thanks.
> both suggestions sound reasonable.
> however, I will search for the root cause of the unaligned address
> first before changing the Meson NFC driver.
That is good. And i will implement one of both mentioned above soon.
>
> [...]
>>> [ 2.227374] ------------[ cut here ]------------
>>> [ 2.231968] WARNING: CPU: 1 PID: 1 at
>>> drivers/mtd/nand/raw/nand_base.c:5503 nand_scan_with_ids+0x1718/0x171c
>>> [ 2.241760] No oob scheme defined for oobsize 1280
>>> ...
>>> (the "No oob scheme defined for oobsize 1280" message is expected)
>>>
>> miss mtd_set_ooblayout(mtd, &meson_ooblayout_ops) on function
>> meson_nand_attach_chip.
> thank you for the suggestion. I didn't have time to test this on my
> board yet but I'll let you know about my results during the weekend.
> Does the missing mtd_set_ooblayout() call also affect GXL or AXG boards?
>
Yes. I deleted it unintentionally.
>
> Regards
> Martin
>
> .
>
prev parent reply other threads:[~2019-03-21 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 18:29 [RFC PATCH nand-next 0/2] meson-nand: support for older SoCs Martin Blumenstingl
2019-03-01 18:29 ` [RFC PATCH nand-next 1/2] dt-bindings: nand: meson: add support for more SoCs Martin Blumenstingl
2019-03-01 18:29 ` [RFC PATCH nand-next 2/2] mtd: rawnand: meson: support for older SoCs up to Meson8 Martin Blumenstingl
2019-03-04 4:56 ` [RFC PATCH nand-next 0/2] meson-nand: support for older SoCs Liang Yang
2019-03-05 22:12 ` Martin Blumenstingl
2019-03-07 13:09 ` Miquel Raynal
2019-03-07 13:36 ` Liang Yang
2019-03-12 9:06 ` Liang Yang
2019-03-16 10:55 ` Martin Blumenstingl
2019-03-19 20:27 ` Martin Blumenstingl
2019-03-20 3:33 ` Liang Yang
2019-03-20 20:48 ` Martin Blumenstingl
2019-03-21 12:10 ` Liang Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aebeb86-1cf6-26e9-b19b-03c2a55bff9c@amlogic.com \
--to=liang.yang@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).