From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE57C433F5 for ; Fri, 7 Oct 2022 14:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiJGO6w (ORCPT ); Fri, 7 Oct 2022 10:58:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiJGO6W (ORCPT ); Fri, 7 Oct 2022 10:58:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8AB10B7B1 for ; Fri, 7 Oct 2022 07:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665154652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N4bh1NN9tgTX7cJpj5y0BC71k+dzF97OkLvXcrjvyMc=; b=exvrd4xcXJbpUFeJhwTNAHP3nU6JrDAaJ6TY7aQM5dzOjH1YYiObE0isgt1B/TA6DbgU2e X0YWlay5Qvx9PHePn/wD4ma7CLVsKyykveEbFAppQeFOj0C8+jnC5TexoJVEicwkCseVnm nw2R9PpiDmcY9qaNWHK6JE7DZTGEqVU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-Lk67Qyt-NXyii8iiu9ikHQ-1; Fri, 07 Oct 2022 10:57:28 -0400 X-MC-Unique: Lk67Qyt-NXyii8iiu9ikHQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D5A5100DEA4; Fri, 7 Oct 2022 14:57:27 +0000 (UTC) Received: from [10.22.18.97] (unknown [10.22.18.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34CDC63AE9; Fri, 7 Oct 2022 14:57:26 +0000 (UTC) Message-ID: <2afd6a8c-016b-0a7c-8574-d2a10641938f@redhat.com> Date: Fri, 7 Oct 2022 10:57:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v10 3/5] sched: Enforce user requested affinity Content-Language: en-US To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Tejun Heo , Zefan Li , Johannes Weiner , Will Deacon , linux-kernel@vger.kernel.org, Linus Torvalds , Lai Jiangshan References: <20220922180041.1768141-1-longman@redhat.com> <20220922180041.1768141-4-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/22 06:01, Peter Zijlstra wrote: > On Thu, Sep 22, 2022 at 02:00:39PM -0400, Waiman Long wrote: >> @@ -9647,6 +9656,9 @@ void __init sched_init(void) >> cpumask_size(), GFP_KERNEL, cpu_to_node(i)); >> per_cpu(select_rq_mask, i) = (cpumask_var_t)kzalloc_node( >> cpumask_size(), GFP_KERNEL, cpu_to_node(i)); >> + per_cpu(runqueues.scratch_mask, i) = >> + (cpumask_var_t)kzalloc_node(cpumask_size(), >> + GFP_KERNEL, cpu_to_node(i)); >> } >> #endif /* CONFIG_CPUMASK_OFFSTACK */ >> > That doesn't actually apply; I've made it: > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -9748,6 +9748,7 @@ void __init sched_init(void) > > rq->core_cookie = 0UL; > #endif > + zalloc_cpumask_var_node(&per_cpu(runqueues.scratch_mask, i), GFP_KERNEL, cpu_to_node(i)); > } > > set_load_weight(&init_task, false); > Sorry, I should have worked on the latest tip tree instead. Thanks, Longman