From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: dillon.minfei@gmail.com, mchehab@kernel.org,
mchehab+huawei@kernel.org, ezequiel@collabora.com,
gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org, gabriel.fernandez@st.com,
gabriel.fernandez@foss.st.com
Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 6/8] media: v4l2-ctrls: Add RGB color effects control
Date: Thu, 14 Oct 2021 12:43:59 +0200 [thread overview]
Message-ID: <2b0739f1-85e4-6b19-ff30-2587f0c622c2@xs4all.nl> (raw)
In-Reply-To: <1634207106-7632-7-git-send-email-dillon.minfei@gmail.com>
On 14/10/2021 12:25, dillon.minfei@gmail.com wrote:
> From: Dillon Min <dillon.minfei@gmail.com>
>
> Add V4L2_COLORFX_SET_RGB color effects control, V4L2_CID_COLORFX_RGB
> for RGB color setting.
>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---
> v4:
> - replace V4L2_COLORFX_SET_ARGB, V4L2_CID_COLORFX_ARGB to
> V4L2_COLORFX_SET_RGB, V4L2_CID_COLORFX_RGB since Alpha paramter not used
> in current. thanks Hans.
>
> Documentation/userspace-api/media/v4l/control.rst | 9 +++++++++
> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 2 ++
> include/uapi/linux/v4l2-controls.h | 4 +++-
> 3 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/control.rst b/Documentation/userspace-api/media/v4l/control.rst
> index f8d0b923da20..3eec65174260 100644
> --- a/Documentation/userspace-api/media/v4l/control.rst
> +++ b/Documentation/userspace-api/media/v4l/control.rst
> @@ -242,8 +242,17 @@ Control IDs
> * - ``V4L2_COLORFX_SET_CBCR``
> - The Cb and Cr chroma components are replaced by fixed coefficients
> determined by ``V4L2_CID_COLORFX_CBCR`` control.
> + * - ``V4L2_COLORFX_SET_RGB``
> + - The RGB components are replaced by the fixed RGB components determined
> + by ``V4L2_CID_COLORFX_RGB`` control.
>
>
> +``V4L2_CID_COLORFX_RGB`` ``(integer)``
> + Determines the Red, Green, and Blue coefficients for
> + ``V4L2_COLORFX_SET_RGB`` color effect.
> + Bits [7:0] of the supplied 32 bit value are interpreted as Blue component,
> + bits [15:8] as Green component, bits [23:16] as Red component, and
> + bits [31:24] must be zero.
>
> ``V4L2_CID_COLORFX_CBCR`` ``(integer)``
> Determines the Cb and Cr coefficients for ``V4L2_COLORFX_SET_CBCR``
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/v4l2-core/v4l2-ctrls-defs.c
> index 421300e13a41..f4bd90170105 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c
> @@ -785,6 +785,7 @@ const char *v4l2_ctrl_get_name(u32 id)
> case V4L2_CID_MIN_BUFFERS_FOR_OUTPUT: return "Min Number of Output Buffers";
> case V4L2_CID_ALPHA_COMPONENT: return "Alpha Component";
> case V4L2_CID_COLORFX_CBCR: return "Color Effects, CbCr";
> + case V4L2_CID_COLORFX_RGB: return "Color Effects, RGB";
>
> /*
> * Codec controls
> @@ -1392,6 +1393,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
> *min = *max = *step = *def = 0;
> break;
> case V4L2_CID_BG_COLOR:
> + case V4L2_CID_COLORFX_RGB:
> *type = V4L2_CTRL_TYPE_INTEGER;
> *step = 1;
> *min = 0;
Can you make another small change here? Please change:
*max = 0xFFFFFF;
to:
*max = 0xffffff;
to keep in line with the coding standard for hex values.
Also, can you add a separate patch that adds an entry here for V4L2_CID_COLORFX_CBCR
that sets *max to 0xffff? I noticed that that was missing. While adding V4L2_CID_COLORFX_RGB
it's good to fix V4L2_CID_COLORFX_CBCR as well.
Regards,
Hans
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 5532b5f68493..9aa3fd368383 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -128,6 +128,7 @@ enum v4l2_colorfx {
> V4L2_COLORFX_SOLARIZATION = 13,
> V4L2_COLORFX_ANTIQUE = 14,
> V4L2_COLORFX_SET_CBCR = 15,
> + V4L2_COLORFX_SET_RGB = 16,
> };
> #define V4L2_CID_AUTOBRIGHTNESS (V4L2_CID_BASE+32)
> #define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+33)
> @@ -145,9 +146,10 @@ enum v4l2_colorfx {
>
> #define V4L2_CID_ALPHA_COMPONENT (V4L2_CID_BASE+41)
> #define V4L2_CID_COLORFX_CBCR (V4L2_CID_BASE+42)
> +#define V4L2_CID_COLORFX_RGB (V4L2_CID_BASE+43)
>
> /* last CID + 1 */
> -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+43)
> +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+44)
>
> /* USER-class private control IDs */
>
>
next prev parent reply other threads:[~2021-10-14 10:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 10:24 [PATCH v4 0/8] Add support for DMA2D of STMicroelectronics STM32 Soc series dillon.minfei
2021-10-14 10:24 ` [PATCH v4 1/8] media: admin-guide: add stm32-dma2d description dillon.minfei
2021-10-14 10:25 ` [PATCH v4 2/8] media: dt-bindings: media: add document for STM32 DMA2d bindings dillon.minfei
2021-10-14 10:25 ` [PATCH v4 3/8] ARM: dts: stm32: Add DMA2D support for STM32F429 series soc dillon.minfei
2021-10-14 10:25 ` [PATCH v4 4/8] ARM: dts: stm32: Enable DMA2D on STM32F469-DISCO board dillon.minfei
2021-10-14 10:25 ` [PATCH v4 5/8] media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform dillon.minfei
2021-10-14 10:25 ` [PATCH v4 6/8] media: v4l2-ctrls: Add RGB color effects control dillon.minfei
2021-10-14 10:43 ` Hans Verkuil [this message]
2021-10-14 10:53 ` Dillon Min
2021-10-14 11:22 ` Hans Verkuil
2021-10-14 14:00 ` Dillon Min
2021-10-14 10:25 ` [PATCH v4 7/8] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell dillon.minfei
2021-10-14 10:25 ` [PATCH v4 8/8] media: stm32-dma2d: STM32 DMA2D driver dillon.minfei
2021-10-14 10:45 ` Hans Verkuil
2021-10-14 11:01 ` Dillon Min
2021-10-14 11:02 ` [PATCH v4 0/8] Add support for DMA2D of STMicroelectronics STM32 Soc series Hans Verkuil
2021-10-14 11:08 ` Dillon Min
2021-10-14 11:14 ` Hans Verkuil
2021-10-14 14:09 ` Dillon Min
2021-10-15 13:12 ` Dillon Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b0739f1-85e4-6b19-ff30-2587f0c622c2@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gabriel.fernandez@foss.st.com \
--cc=gabriel.fernandez@st.com \
--cc=gnurou@gmail.com \
--cc=hugues.fruchet@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=patrice.chotard@foss.st.com \
--cc=pihsun@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).