From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDE1C35DEE for ; Tue, 25 Feb 2020 01:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FDF22176D for ; Tue, 25 Feb 2020 01:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728703AbgBYBiX convert rfc822-to-8bit (ORCPT ); Mon, 24 Feb 2020 20:38:23 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:3023 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728011AbgBYBiX (ORCPT ); Mon, 24 Feb 2020 20:38:23 -0500 Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 4CAD1CD3441B7653DC3F; Tue, 25 Feb 2020 09:38:19 +0800 (CST) Received: from dggeme752-chm.china.huawei.com (10.3.19.98) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Feb 2020 09:38:19 +0800 Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme752-chm.china.huawei.com (10.3.19.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 25 Feb 2020 09:38:18 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1713.004; Tue, 25 Feb 2020 09:38:18 +0800 From: linmiaohe To: Vitaly Kuznetsov CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "sean.j.christopherson@intel.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" Subject: Re: [PATCH RESEND] KVM: X86: eliminate obsolete KVM_GET_CPUID2 ioctl Thread-Topic: [PATCH RESEND] KVM: X86: eliminate obsolete KVM_GET_CPUID2 ioctl Thread-Index: AdXre4dKrht1i82DQRSoVD2o89y1Sw== Date: Tue, 25 Feb 2020 01:38:18 +0000 Message-ID: <2b1648f550814556b27a22259a2d9125@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vitaly Kuznetsov writes: >linmiaohe writes: > >> KVM_GET_CPUID2 ioctl is straight up broken > >It may make sense to add the gory details from your previous patch where you were trying to fix it. Will do. >> and not used anywhere. Remove it directly. >> >> Suggested-by: Paolo Bonzini >> Signed-off-by: Miaohe Lin >> #define KVM_GET_LAPIC _IOR(KVMIO, 0x8e, struct kvm_lapic_state) >> #define KVM_SET_LAPIC _IOW(KVMIO, 0x8f, struct kvm_lapic_state) >> #define KVM_SET_CPUID2 _IOW(KVMIO, 0x90, struct kvm_cpuid2) >> -#define KVM_GET_CPUID2 _IOWR(KVMIO, 0x91, struct kvm_cpuid2) > >Even if we decide to be strong and remove KVM_GET_CPUID2 completely, I'd suggest we leave a comment here saying that it was deprecated. Leaving the branch in case (returning the same -EINVAL as passing an unsupported >IOCTL) may also make sense (with a 'deprecated' comment of course). > Sounds reasonable. Will try. Many thanks!